Improve performance of importing models with validations #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkowens
force-pushed
the
model_validation
branch
from
c2560a5
to
ea02391
Compare
| if models | ||
| import_with_validations( column_names, array_of_attributes, options ) do |failed| | ||
| models.each_with_index do |model, i| | ||
| model = model.dup if options[:recursive] |
There was a problem hiding this comment.
Duping the model was necessary when the :recursive option was set so that the parent model would be imported even if child associations failed validation. This is apparently the desired behavior since it is described in this test.
jkowens
force-pushed
the
model_validation
branch
from
ea02391
to
da97eb4
Compare
| @@ -350,12 +350,7 @@ def import_helper( *args ) | |||
| # this next line breaks sqlite.so with a segmentation fault | |||
| # if model.new_record? || options[:on_duplicate_key_update] | |||
| column_names.map do |name| | |||
| name = name.to_s | |||
| if respond_to?(:defined_enums) && defined_enums.key?(name) # ActiveRecord 5 | |||
There was a problem hiding this comment.
This logic doesn't seem to be necessary if models aren't converted to arrays of values and then back to models for validation.
jkowens
force-pushed
the
model_validation
branch
from
da97eb4
to
0d92ef2
Compare
jkowens
force-pushed
the
model_validation
branch
from
0d92ef2
to
3a4a15a
Compare
jkowens
changed the title
jkowens
force-pushed
the
model_validation
branch
2 times, most recently
from
37a24d8
to
92dbc36
Compare
| # keep track of the instance and the position it is currently at. if this fails | ||
| # validation we'll use the index to remove it from the array_of_attributes | ||
| model = new | ||
| arr.each_with_index do |hsh, i| | ||
| hsh.each_pair { |k, v| model[k] = v } |
There was a problem hiding this comment.
@zdennis instead of instantiating a new instance for every record, here I changed it to instantiate one instance and just update the attributes on that model. If it fails validation, the model is then duped.
jkowens
force-pushed
the
model_validation
branch
from
92dbc36
to
d0322ab
Compare
|
Thanks @jkowens ! |
|
This will go out in the 0.14.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when validating models on import, the models are converted to arrays of values and then are reinitialized as models to call
valid?It seems unnecessary to do this extra reinitialization step. Inspired by #118.Running the MySQL benchmarks on my laptop shows a 2x performance increase (over previous implementation) for importing models with validations.