validate using given models instead of re-initializing ones #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, if some of the validations work on associations, they will re-load the association instead of using the one in the given model, thus making N queries when you wanted just 1 INSERT. |
| @@ -216,7 +216,25 @@ def import( *args ) | |||
| end | |||
|
|
|||
| return_obj = if is_validating | |||
| import_with_validations( column_names, array_of_attributes, options ) | |||
| if models | |||
There was a problem hiding this comment.
I love the idea @giladas, I was thinking about submitting a pull request for exactly this a few days ago.
Since this is more or less the same validation logic as in import_with_validations, perhaps there is a way we can DRY the logic up?
|
This has been implemented by #266. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when using import with models and validations are enabled, the models are converted to arrays, re-initialized and then the validation process is taking place. It's not necessary to re-initialize the models since they were given as parameters, and it took more time than the actual db insert.