Lint #287
Lint #287
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe changes introduce several enhancements across multiple files, including the addition of a GitHub Actions workflow for reverse dependency checks, updates to linting configurations, and improvements in documentation and testing for the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHubActions
participant recheckWorkflow
User->>GitHubActions: Trigger reverse dependency check
GitHubActions->>recheckWorkflow: Execute recheck with parameters
recheckWorkflow-->>User: Return results of the dependency check
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Outside diff range, codebase verification and nitpick comments (1)
revdep/README.md (1)
19-19: Fix the missing punctuation.A punctuation mark might be missing here.
- |Δ | + |Δ |.Tools
LanguageTool
[uncategorized] ~19-~19: A punctuation mark might be missing here.
Context: ...|Δ | |:-------------|:-----|:-----|:--| |caretEnsemble |2.0.3 |2.0.4 |* | # Re...(AI_EN_LECTOR_MISSING_PUNCTUATION)
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (18)
- .github/workflows/recheck.yml (1 hunks)
- .lintr (1 hunks)
- R/caretEnsemble.R (1 hunks)
- R/caretList.R (10 hunks)
- R/caretStack.R (3 hunks)
- R/helper_functions.R (11 hunks)
- man/caretStack.Rd (2 hunks)
- man/dotplot.caretStack.Rd (1 hunks)
- revdep/README.md (1 hunks)
- tests/testthat/test-S3-generic-extensions.R (11 hunks)
- tests/testthat/test-caretEnsemble.R (7 hunks)
- tests/testthat/test-caretList.R (12 hunks)
- tests/testthat/test-caretStack.R (8 hunks)
- tests/testthat/test-classSelection.R (3 hunks)
- tests/testthat/test-ensembleMethods.R (1 hunks)
- tests/testthat/test-helper_functions.R (10 hunks)
- tests/testthat/test-multiclass.R (8 hunks)
- vignettes/caretEnsemble-intro.Rmd (6 hunks)
Files skipped from review due to trivial changes (6)
- R/caretList.R
- R/caretStack.R
- R/helper_functions.R
- man/caretStack.Rd
- man/dotplot.caretStack.Rd
- tests/testthat/test-ensembleMethods.R
Additional context used
LanguageTool
revdep/README.md
[uncategorized] ~19-~19: A punctuation mark might be missing here.
Context: ...|Δ | |:-------------|:-----|:-----|:--| |caretEnsemble |2.0.3 |2.0.4 |* | # Re...(AI_EN_LECTOR_MISSING_PUNCTUATION)
Additional comments not posted (62)
.github/workflows/recheck.yml (3)
1-10: LGTM! The workflow dispatch event and inputs are well-defined.The
workflow_dispatchevent allows manual triggering of the workflow with inputs, which are clearly defined.
11-11: LGTM! The workflow name is clear and descriptive.The name "Reverse dependency check" accurately describes the purpose of the workflow.
13-18: LGTM! The job configuration is clear and correctly uses an external workflow.The job
revdep_checkuses an external workflow and correctly passes the inputwhichto it.revdep/README.md (2)
3-14: LGTM! The platform metadata updates are appropriate.The updates reflect new versions of R, macOS, architecture, UI, and Pandoc, keeping the environment up-to-date.
20-20: LGTM! The dependency update is appropriate.The update reflects a minor version change for the
caretEnsemblepackage from 2.0.3 to 2.0.4..lintr (2)
3-17: LGTM! The updates to the linter tags are appropriate.The new tags added enhance the categorization of linting rules, improving clarity and organization.
20-26: LGTM! The updates to the linters are appropriate.The changes include adding new linters, adjusting existing ones, and marking some for future refactoring, aligning with best practices for code quality checks.
tests/testthat/test-classSelection.R (3)
15-15: Improved readability with explicit numeric literal.Using
0.8instead of.8enhances readability and clarity.
29-29: Improved test specificity withexpect_length.Replacing
expect_equalwithexpect_lengthenhances the specificity of the test assertions.
70-77: Enhanced readability with multilineifelsestatement.Reformatting the
ifelsestatement into a multiline structure improves readability and clarity.tests/testthat/test-S3-generic-extensions.R (11)
76-77: Improved clarity and specificity in assertions.Replacing
expect_true(length(names(bigList)) == length(unique(names(bigList))))withexpect_identical(anyDuplicated(names(bigList)), 0L)andexpect_equal(length(unique(names(bigList))), 4)withexpect_length(unique(names(bigList)), 4)enhances the clarity and specificity of the assertions.
86-87: Improved clarity and specificity in assertions.Replacing
expect_true(length(names(bigList)) == length(unique(names(bigList))))withexpect_identical(anyDuplicated(names(bigList)), 0L)andexpect_equal(length(unique(names(bigList))), 3)withexpect_length(unique(names(bigList)), 3)enhances the clarity and specificity of the assertions.
106-107: Improved clarity and specificity in assertions.Replacing
expect_true(length(names(bigList)) == length(unique(names(bigList))))withexpect_identical(anyDuplicated(names(bigList)), 0L)andexpect_equal(length(unique(names(bigList))), 2)withexpect_length(unique(names(bigList)), 2)enhances the clarity and specificity of the assertions.
131-131: Improved clarity and specificity in assertion.Replacing
expect_equal(length(unique(names(bigList))), length(models.class))withexpect_length(combined_models, length(models.class))enhances the clarity and specificity of the assertion.
143-143: Improved clarity and specificity in assertion.Replacing
expect_equal(length(unique(names(bigList))), 3)withexpect_length(combined_models, 3)enhances the clarity and specificity of the assertion.
154-154: Improved clarity and specificity in assertion.Replacing
expect_equal(length(unique(names(bigList))), 2)withexpect_length(combined_models, 2)enhances the clarity and specificity of the assertion.
166-166: Improved clarity and specificity in assertion.Replacing
expect_equal(length(unique(names(bigList))), 4)withexpect_length(combined_models, 4)enhances the clarity and specificity of the assertion.
179-179: Improved clarity and specificity in assertion.Replacing
expect_equal(length(unique(names(bigList))), 2)withexpect_length(subset_models, 2)enhances the clarity and specificity of the assertion.
188-188: Improved clarity and specificity in assertion.Replacing
expect_equal(length(unique(names(bigList))), 2)withexpect_length(caretlist_object, 2)enhances the clarity and specificity of the assertion.
202-202: Improved clarity and specificity in assertion.Replacing
expect_equal(names(cl), unname(sapply(models.class, "[[", "method")))withexpect_named(cl, unname(sapply(models.class, "[[", "method")))enhances the clarity and specificity of the assertion.
224-224: Improved clarity and specificity in assertion.Replacing
expect_equal(ncol(class_probs), length(models.class) * nlevels(Y.class))withexpect_equal(ncol(class_probs), length(models.class) * nlevels(Y.class))enhances the clarity and specificity of the assertion.tests/testthat/test-caretEnsemble.R (7)
58-58: Improved clarity and specificity in assertions.Replacing
expect_true(is.numeric(r))withexpect_is(r, "numeric")andexpect_equal(length(r), 150)withexpect_length(r, 150)enhances the clarity and specificity of the assertions.
75-76: Improved clarity and specificity in assertions.Replacing
expect_true(is.numeric(pred.reg))withexpect_type(pred.reg, "double")andexpect_equal(length(pred.reg), 150)withexpect_length(pred.reg, 150L)enhances the clarity and specificity of the assertions.
80-81: Improved clarity and specificity in assertions.Replacing
expect_true(is.data.frame(pred.class))withexpect_s3_class(pred.class, "data.frame")andexpect_true(nrow(pred.class) == 150)withexpect_equal(nrow(pred.class), 150L)enhances the clarity and specificity of the assertions.
92-92: Improved clarity and specificity in assertion.Replacing
expect_true(all(names(p2) == c("fit", "lwr", "upr")))withexpect_named(p2, c("fit", "lwr", "upr"))enhances the clarity and specificity of the assertion.
96-96: Improved clarity and specificity in assertion.Replacing
expect_true(all(p1 == p3))withexpect_equivalent(p1, p3)enhances the clarity and specificity of the assertion.
142-143: Improved clarity and specificity in assertions.Replacing
expect_true(is.numeric(pred.nest))withexpect_type(pred.nest, "double")andexpect_equal(length(pred.nest), 150)withexpect_length(pred.nest, 150)enhances the clarity and specificity of the assertions.
166-166: Improved clarity and specificity in assertion.Replacing
expect_true(length(pred.regc) == 1)withexpect_length(pred.regc, 1)enhances the clarity and specificity of the assertion.vignettes/caretEnsemble-intro.Rmd (1)
12-18: LGTM! Library calls improve clarity.The added library calls for
caretEnsemble,caret,mlbench,plyr, andcaToolsimprove clarity regarding dependencies.tests/testthat/test-caretStack.R (3)
25-26: LGTM! Improved readability and specificity in assertions.The use of
expect_typeandexpect_lengthimproves readability and ensures that the expected types and lengths are checked directly.
41-44: LGTM! Stricter comparison for row count.The use of
expect_identicalensures both the value and type are the same, providing a stricter comparison.
128-128: LGTM! More efficient method for generating random indices.The update from
sampletosample.intis more efficient and idiomatic.tests/testthat/test-multiclass.R (7)
28-28: LGTM! Improved readability with specific expectation function.The use of
expect_lengthimproves readability by using a more specific expectation function.
98-98: LGTM! Semantically accurate checks.The use of
expect_lengthensures that the checks are more semantically accurate and aligned with the intended functionality.
127-136: LGTM! Enhanced readability and maintainability.The formatting changes to the
tuneListwithin thecaretModelSpecenhance readability and maintainability without altering the logic.
161-161: LGTM! More efficient method for generating training indices.The update from
sample(seq_len(n), n * 0.8)tosample.int(n, n * 0.8)is more efficient and idiomatic.
192-192: LGTM! Clearer accuracy assertion.The refinement from
expect_true(cm$overall["Accuracy"] > 0.9)toexpect_gt(cm$overall["Accuracy"], 0.9)makes it clearer that the test checks for a value greater than 0.9.
308-309: LGTM! More explicit class type check.The change from
expect_true(is.ordered(preds))toexpect_s3_class(preds, "ordered")provides a more explicit check for the class type.
335-335: LGTM! Consistent and accurate probability predictions.The check ensures that the sum of probabilities is close to 1, confirming the consistency and accuracy of probability predictions.
R/caretEnsemble.R (1)
212-212: LGTM! The addition offixed = TRUEtogrepimproves performance and ensures literal matching.This change enhances the efficiency and correctness of the string matching process.
tests/testthat/test-helper_functions.R (12)
58-59: LGTM! The use ofexpect_lengthimproves the clarity of the test.This change makes the test more readable and specific.
76-77: LGTM! The use ofexpect_lengthimproves the clarity of the test.This change makes the test more readable and specific.
119-119: LGTM! The use ofexpect_equalwith tolerance improves the clarity of the test.This change makes the test more readable and specific.
128-131: LGTM! The use ofexpect_falsefor NA checks improves the clarity of the test.This change makes the test more readable and specific.
146-147: LGTM! The use ofexpect_errorfor error checks improves the clarity of the test.This change makes the test more readable and specific.
364-365: LGTM! The use ofexpect_namedimproves the clarity of the test.This change makes the test more readable and specific.
371-372: LGTM! The use ofexpect_errorimproves the clarity of the test.This change makes the test more readable and specific.
378-379: LGTM! The use ofexpect_errorimproves the clarity of the test.This change makes the test more readable and specific.
385-386: LGTM! The use ofexpect_errorimproves the clarity of the test.This change makes the test more readable and specific.
392-393: LGTM! The use ofexpect_errorimproves the clarity of the test.This change makes the test more readable and specific.
431-436: LGTM! The use ofexpect_namedimproves the clarity of the test.This change makes the test more readable and specific.
83-83: Consider usingexpect_identicalfor dimension checks.Use
expect_identicalinstead ofexpect_true(all(dim(out) == c(150L, 4L)))for better readability.- expect_true(all(dim(out) == c(150L, 4L))) + expect_identical(dim(out), c(150L, 4L))Likely invalid or redundant comment.
tests/testthat/test-caretList.R (10)
28-29: LGTM! The use ofexpect_typeandexpect_lengthimproves the clarity of the test.This change makes the test more readable and specific.
42-49: LGTM! The use ofexpect_lengthimproves the clarity of the test.This change makes the test more readable and specific.
83-94: LGTM! The use ofexpect_errorandexpect_isimproves the clarity of the test.This change makes the test more readable and specific.
119-127: LGTM! The use ofexpect_namedimproves the clarity of the test.This change makes the test more readable and specific.
189-190: LGTM! The updated error message improves clarity.This change makes the error message more readable and specific.
196-197: LGTM! The updated error message improves clarity.This change makes the error message more readable and specific.
200-200: LGTM! The updated error message improves clarity.This change makes the error message more readable and specific.
217-236: LGTM! The use ofexpect_namedimproves the clarity of the test.This change makes the test more readable and specific.
678-679: LGTM! The updated error message improves clarity.This change makes the error message more readable and specific.
699-700: LGTM! The updated error message improves clarity.This change makes the error message more readable and specific.
add reverse deps check library_call_linter length_levels_linter any_duplicated_linter unnecessary_concatenation_linter fixed_regex_linter styler comparison_negation_linter consecutive_assertion_linter comparison_negation_linter numeric_leading_zero_linter sample_int_linter strings_as_factors_linter enable most tags expect_length_linter expect_length_linter expect_comparison_linter expect_comparison_linter expect_null_linter expect_comparison_linter expect_not_linter fix-tests expect_named_linter expect_type_linter expect_s3_class fix-tests 120-line-len rebuild Update tests/testthat/test-helper_functions.R Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Update tests/testthat/test-helper_functions.R Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> names more lint rebuild fix a bunch of lint monster delint test test test test test
|
@coderabbitai review |
Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (31)
- .github/workflows/recheck.yml (1 hunks)
- .lintr (1 hunks)
- R/S3GenericExtenstions.R (2 hunks)
- R/caretEnsemble.R (10 hunks)
- R/caretList.R (12 hunks)
- R/caretStack.R (5 hunks)
- R/helper_functions.R (17 hunks)
- cobertura.xml (4 hunks)
- inst/data-raw/build_test_data.R (4 hunks)
- man/caretList.Rd (1 hunks)
- man/caretModelSpec.Rd (1 hunks)
- man/caretStack.Rd (2 hunks)
- man/dotplot.caretStack.Rd (1 hunks)
- man/extractBestPredsAndObs.Rd (1 hunks)
- man/extractCaretTarget.Rd (1 hunks)
- man/extractCaretTarget.default.Rd (1 hunks)
- man/methodCheck.Rd (1 hunks)
- man/trControlCheck.Rd (1 hunks)
- man/tuneCheck.Rd (1 hunks)
- man/validateExcludedClass.Rd (1 hunks)
- revdep/README.md (1 hunks)
- tests/testthat/test-S3-generic-extensions.R (10 hunks)
- tests/testthat/test-caretEnsemble.R (6 hunks)
- tests/testthat/test-caretList.R (31 hunks)
- tests/testthat/test-caretStack.R (13 hunks)
- tests/testthat/test-classSelection.R (7 hunks)
- tests/testthat/test-ensembleMethods.R (8 hunks)
- tests/testthat/test-helper_functions.R (16 hunks)
- tests/testthat/test-multiclass.R (14 hunks)
- tests/testthat/test-parallel.R (1 hunks)
- vignettes/caretEnsemble-intro.Rmd (6 hunks)
Files skipped from review due to trivial changes (15)
- R/caretList.R
- R/caretStack.R
- R/helper_functions.R
- inst/data-raw/build_test_data.R
- man/caretList.Rd
- man/caretModelSpec.Rd
- man/caretStack.Rd
- man/extractBestPredsAndObs.Rd
- man/extractCaretTarget.Rd
- man/extractCaretTarget.default.Rd
- man/methodCheck.Rd
- man/trControlCheck.Rd
- man/tuneCheck.Rd
- man/validateExcludedClass.Rd
- tests/testthat/test-parallel.R
Files skipped from review as they are similar to previous changes (13)
- .github/workflows/recheck.yml
- .lintr
- R/caretEnsemble.R
- man/dotplot.caretStack.Rd
- tests/testthat/test-S3-generic-extensions.R
- tests/testthat/test-caretEnsemble.R
- tests/testthat/test-caretList.R
- tests/testthat/test-caretStack.R
- tests/testthat/test-classSelection.R
- tests/testthat/test-ensembleMethods.R
- tests/testthat/test-helper_functions.R
- tests/testthat/test-multiclass.R
- vignettes/caretEnsemble-intro.Rmd
Additional context used
LanguageTool
revdep/README.md
[uncategorized] ~19-~19: A punctuation mark might be missing here.
Context: ...|Δ | |:-------------|:-----|:-----|:--| |caretEnsemble |2.0.3 |2.0.4 |* | # Re...(AI_EN_LECTOR_MISSING_PUNCTUATION)
Additional comments not posted (49)
revdep/README.md (7)
5-5: Update R version.The R version has been updated to 4.4.1. Ensure that all dependencies and compatibility issues are addressed with this version.
6-6: Update OS version.The OS has been updated to macOS Sonoma 14.5. Verify that the new OS version is compatible with all dependencies and tools used in the project.
7-7: Update system architecture.The system architecture has been updated to aarch64. Ensure that all dependencies and tools support this architecture.
8-8: Update UI.The UI has been changed to X11. Verify that this change does not affect the user experience or functionality.
13-13: Update date.The date has been updated to 2024-07-24. Ensure that this date reflects the actual update time.
14-14: Update Pandoc version.The Pandoc version has been updated to 3.2.1. Verify that the new version is compatible with the project requirements.
20-20: Update caretEnsemble version.The caretEnsemble package version has been updated from 2.0.3 to 2.0.4. Ensure that the new version does not introduce any breaking changes.
R/S3GenericExtenstions.R (4)
38-45: Simplify conditional logic.The conditional logic has been simplified for better readability. This change improves the maintainability of the code.
42-42: Use explicit list indexing.The method name is accessed using
x[[1L]]instead ofx[[1]]. This change is more explicit and improves code clarity.
85-92: Simplify conditional logic.The conditional logic has been simplified for better readability. This change improves the maintainability of the code.
89-89: Use explicit list indexing.The method name is accessed using
x[[1L]]instead ofx[[1]]. This change is more explicit and improves code clarity.cobertura.xml (38)
3-3: Update coverage metrics.The line coverage metrics have been updated, indicating improved test coverage. Ensure that the new metrics accurately reflect the test coverage.
445-445: Update line hits forcaretModelSpec.The line hits for the
caretModelSpecmethod have been updated. Verify that the changes accurately reflect the test coverage.
451-461: Update line hits fortuneCheck.The line hits for the
tuneCheckmethod have been updated. Verify that the changes accurately reflect the test coverage.
466-486: Update line hits formethodCheck.The line hits for the
methodCheckmethod have been updated. Verify that the changes accurately reflect the test coverage.
492-516: Update line hits fortrControlCheck.The line hits for the
trControlCheckmethod have been updated. Verify that the changes accurately reflect the test coverage.
521-521: Update line hits forextractCaretTarget.The line hits for the
extractCaretTargetmethod have been updated. Verify that the changes accurately reflect the test coverage.
526-526: Update line hits forextractCaretTarget.default.The line hits for the
extractCaretTarget.defaultmethod have been updated. Verify that the changes accurately reflect the test coverage.
531-533: Update line hits forextractCaretTarget.formula.The line hits for the
extractCaretTarget.formulamethod have been updated. Verify that the changes accurately reflect the test coverage.
538-568: Update line hits forcaretList.The line hits for the
caretListmethod have been updated. Verify that the changes accurately reflect the test coverage.
573-573: Update line hits foris.caretList.The line hits for the
is.caretListmethod have been updated. Verify that the changes accurately reflect the test coverage.
578-580: Update line hits foras.caretList.The line hits for the
as.caretListmethod have been updated. Verify that the changes accurately reflect the test coverage.
585-585: Update line hits foras.caretList.default.The line hits for the
as.caretList.defaultmethod have been updated. Verify that the changes accurately reflect the test coverage.
590-598: Update line hits foras.caretList.list.The line hits for the
as.caretList.listmethod have been updated. Verify that the changes accurately reflect the test coverage.
603-604: Update line hits for[.caretList.The line hits for the
[.caretListmethod have been updated. Verify that the changes accurately reflect the test coverage.
609-631: Update line hits forpredict.caretList.The line hits for the
predict.caretListmethod have been updated. Verify that the changes accurately reflect the test coverage.
778-785: Update line hits forcaretStack.The line hits for the
caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
792-831: Update line hits forpredict.caretStack.The line hits for the
predict.caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
836-836: Update line hits foris.caretStack.The line hits for the
is.caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
841-841: Update line hits forsummary.caretStack.The line hits for the
summary.caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
846-849: Update line hits forprint.caretStack.The line hits for the
print.caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
854-854: Update line hits forplot.caretStack.The line hits for the
plot.caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
859-859: Update line hits fordotplot.caretStack.The line hits for the
dotplot.caretStackmethod have been updated. Verify that the changes accurately reflect the test coverage.
930-955: Update line hits forvalidateExcludedClass.The line hits for the
validateExcludedClassmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
71-78:
Update line hits fordropExcludedClass.The line hits for the
dropExcludedClassmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
94-99:
Update line hits forextractModelName.The line hits for the
extractModelNamemethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
109-129:
Update line hits forextractBestPreds.The line hits for the
extractBestPredsmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
141-150:
Update line hits forextractModelType.The line hits for the
extractModelTypemethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
157-161:
Update line hits forextractObsLevels.The line hits for the
extractObsLevelsmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
176-220:
Update line hits forextractBestPredsAndObs.The line hits for the
extractBestPredsAndObsmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
235-241:
Update line hits forcheckCustomModel.The line hits for the
checkCustomModelmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
250-254:
Update line hits forcheck_caretList_classes.The line hits for the
check_caretList_classesmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
262-269:
Update line hits forcheck_caretList_model_types.The line hits for the
check_caretList_model_typesmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
296-302:
Update line hits forcheck_bestpreds_resamples.The line hits for the
check_bestpreds_resamplesmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
310-316:
Update line hits forcheck_bestpreds_indexes.The line hits for the
check_bestpreds_indexesmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
324-330:
Update line hits forcheck_bestpreds_obs.The line hits for the
check_bestpreds_obsmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
339-357:
Update line hits forcheck_bestpreds_preds.The line hits for the
check_bestpreds_predsmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
366-374:
Update line hits forcheck_binary_classification.The line hits for the
check_binary_classificationmethod have been updated. Verify that the changes accurately reflect the test coverage.
Line range hint
389-397:
Update line hits forwtd.sd.The line hits for the
wtd.sdmethod have been updated. Verify that the changes accurately reflect the test coverage.
Add a bunch more linters
TODO (follow up PR):
todo_comment_linter - FOLLOW UP PR