-
Notifications
You must be signed in to change notification settings - Fork 75
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add reverse deps check library_call_linter length_levels_linter any_duplicated_linter unnecessary_concatenation_linter fixed_regex_linter styler comparison_negation_linter consecutive_assertion_linter comparison_negation_linter numeric_leading_zero_linter sample_int_linter strings_as_factors_linter enable most tags expect_length_linter expect_length_linter expect_comparison_linter expect_comparison_linter expect_null_linter expect_comparison_linter expect_not_linter fix-tests expect_named_linter expect_type_linter expect_s3_class fix-tests 120-line-len rebuild Update tests/testthat/test-helper_functions.R Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Update tests/testthat/test-helper_functions.R Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> names more lint rebuild fix a bunch of lint monster delint test test test test test
- Loading branch information
Showing
33 changed files
with
4,890 additions
and
4,504 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
which: | ||
type: choice | ||
description: Which dependents to check | ||
options: | ||
- strong | ||
- most | ||
|
||
name: Reverse dependency check | ||
|
||
jobs: | ||
revdep_check: | ||
name: Reverse check ${{ inputs.which }} dependents | ||
uses: r-devel/recheck/.github/workflows/recheck.yml@v1 | ||
with: | ||
which: ${{ inputs.which }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,31 @@ | ||
linters: linters_with_tags( | ||
tags = c( | ||
"best_practices", | ||
"common_mistakes", | ||
"consistency", | ||
"correctness", | ||
"default", | ||
"best_practices", | ||
"common_mistakes", | ||
"correctness", | ||
"executing" | ||
), | ||
"efficiency", | ||
"executing", | ||
"package_development", | ||
"pkg_testthat", | ||
"readability", | ||
"regex", | ||
"robustness", | ||
"style", | ||
"tidy_design" | ||
), | ||
return_linter(), | ||
object_overwrite_linter(), | ||
unnecessary_concatenation_linter(), | ||
cyclocomp_linter(complexity_limit = 19), # TODO small refactor | ||
implicit_integer_linter = NULL, # TODO refactor | ||
library_call_linter = NULL, # TODO refactor | ||
object_length_linter(), | ||
line_length_linter(120), | ||
todo_comment_linter = NULL, # TODO refactor | ||
implicit_assignment_linter = NULL, # TODO refactor | ||
length_levels_linter = NULL, # TODO refactor | ||
any_duplicated_linter = NULL, # TODO refactor | ||
expect_length_linter = NULL, # TODO refactor | ||
expect_comparison_linter = NULL, # TODO refactor | ||
expect_null_linter = NULL, # TODO refactor | ||
expect_not_linter = NULL, # TODO refactor | ||
expect_named_linter = NULL, # TODO refactor | ||
expect_type_linter = NULL, # TODO refactor | ||
expect_s3_class_linter = NULL, # TODO refactor | ||
fixed_regex_linter = NULL, # TODO refactor | ||
redundant_ifelse_linter = NULL, #TODO refactor | ||
expect_identical_linter = NULL, # TODO big refactor | ||
undesirable_function_linter = NULL, # TODO big refactor | ||
line_length_linter(305), # TODO change to 120 - big refactor | ||
object_length_linter(length = 31), # May or may not refactor | ||
nzchar_linter = NULL, # Whats the point of this lintr? | ||
condition_message_linter = NULL, # Whats the point of this lintr? | ||
condition_call_linter = NULL, # Whats the point of this lintr? | ||
paste_linter = NULL, # Probably never gonna remove this one | ||
object_name_linter = NULL # Probably never gonna remove this one | ||
) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.