Eventlog tests and documentation #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AS A developer of a Logout handler I WANT to be able to call a function to kill spawners and do other backend logout stuff and a separate function to forward the user along the logout chain. I believe this PR adds (moderately private) methods to the Logout Handler to do just that.
Big thanks to Erik, Tim, and Min for the great comments! Change names to be more clear, add function doc comments, change scoping on some functions, add handle_logout to let people take custom logout actions, extract render_logout_page from get method, add TODO.
order should be preserved between multiple steps
test postgres with url-encoded password
…ut-handler Refactor Logout Handler
avoids bug in latest connector decoding: https://bugs.mysql.com/bug.php?id=94944
pin mysql-connector-python on travis
preserves link targets, which mangling the directive header does not
[autodoc] move config sample to annotation
releasing 1.0
…side the Elucidata with Jupyterhub
…_use_case Adding the use case of the Elucidata: How Jupyter Notebook is used in…
Update to simplify the language related to spawner options
Dict rewritten as literal
Windows doesn't have support for signal handling so it can't use the signal handling capabilities of asyncio. Use the previous atexit strategy on the Windows case instead. Signed-off-by: Alejandro Del Castillo <alejandro.delcastillo@ni.com>
Fixes jupyterhub#2566 to some degree by making the announcement stand out using twitter-bootstrap classes `alert` and `alert-warning`. Perhaps we could theme twitter bootstrap or this alert specifically with jupyter related colors as well though?
Update link of `changelog`
avoids asyncio tracebacks in e.g. `jupyterhub --version`
re-raise exceptions in launch_instance_async
The default values are taken from environment variables defined by Spawner.get_env.
* Add missing responses (doesn't include all possible responses yet) * Refactor invalid multi in body parameters into a single parameter * Change form type into valid formData * Fix use of required fields * Apply a few other minor fixes
…_to_login /hub/admin redirect to login
Replace header logo: jupyter -> jupyterhub
…-named-servers Add `server_name` to `spawn_url`
Fix failing travis tests
…n-readme Add Jupyter community link
- Introduce the EventLog class from BinderHub for emitting structured event data - Instrument server starts and stops to emit events - Defaults to not saving any events anywhere
They're pure python, and should be ok
jupyterhub still supports Python 3.5
Privacy by default!
Full circle, since the code in jupyter_telemetry came from here: jupyter/telemetry#6
Move it to YAML, since jupyter_telemetry supports these natively.
Zsailer
force-pushed
the
eventlog-tests
branch
from
acc296a
to
439e438
Compare
|
Oops. Sorry, rebased too soon and caused a bunch of spam here. |
|
Closing since I opened jupyterhub#2698 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests to #1 (I'll close that PR).
Here are some initial tests and documentation for the EventLog in JupyterHub.