Initial setup #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jupyterhub still supports Python 3.5
Privacy by default!
This removes the consent GUI screen since I couldn't figure out how to make that work
This lets me play with event schemas without having to worry about packaging them in my package
Not done when using an editable pip install by default
|
Ooooh I like this!!! I'm happy to merge it if you take the WIP off the title. Thanks for kicking this off |
|
Awesome, @yuvipanda. Merge away! 😃 |
|
Done, Thank you! |
|
And I appreciate the cherry-picks :) |
yuvipanda
added a commit
to yuvipanda/jupyterhub
that referenced
this pull request
Jul 9, 2019
Full circle, since the code in jupyter_telemetry came from here: jupyter/telemetry#6
Zsailer
pushed a commit
to Zsailer/jupyterhub
that referenced
this pull request
Aug 22, 2019
Full circle, since the code in jupyter_telemetry came from here: jupyter/telemetry#6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started preparing this repo for development. @jaipreet-s and @yuvipanda
So far, I've cherry-picked @yuvipanda's commits from jupyterhub/jupyterhub#2542 and jupyterlab/jupyterlab-telemetry#1 (I wanted to make sure you got credit for your work! 😃). This includes an initial Configurable
EventLogobject that Jupyter applications can use to begin logging events. I think this is a good starting point.The JS module is essentially blank. It includes a jupyterlab handler that probably doesn't belong in this repo (it just came with the block of commits I cherry-picked).
I propose we merge this PR as is and iterate in separate PRs—I haven't changed the current API to fit the method names described in the JEP. That's the next step. Then, we can begin building up from there.