Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Fix the password reset UI flow #4666

Closed
ramkumarvs opened this issue Jun 3, 2020 · 0 comments
Closed

[Platform] Fix the password reset UI flow #4666

ramkumarvs opened this issue Jun 3, 2020 · 0 comments
Assignees
Labels
area/ui All issues relating to UI/UX priority/high High Priority

Comments

@ramkumarvs
Copy link
Contributor

With RBAC we changed how to the users are managed, we need to make sure the UI flow to reset password is changed accordingly.

take a look at this commit for reference.
b78d0b3

@ramkumarvs ramkumarvs added area/ui All issues relating to UI/UX priority/high High Priority labels Jun 3, 2020
andrewc-dev pushed a commit that referenced this issue Jun 5, 2020
Summary:
Fix password reset flow as a separate API call when user changes the UserProfileForm.
Compare the values on submit to the initial values and determine if a profile and/or a password
change occurred.

The new password submit endpoint was implemented by @arnav in commit: b78d0b3

Test Plan:
1. Change the user's Full name field and submit. Check that the success status message appears on top.
2. Try changing the user's Full name field and the password, and confirm that two API
requests are made. Confirm that the success status message again appears on top. Logout and try logging in with the new password to confirm it works.
3. Try changing only the password and confirm that the success status message appears on top.

Reviewers: ram, wesley, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: kannan, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D8624
andrewc-dev pushed a commit that referenced this issue Jun 8, 2020
Summary:
Fix password reset flow as a separate API call when user changes the UserProfileForm.
Compare the values on submit to the initial values and determine if a profile and/or a password
change occurred.

The new password submit endpoint was implemented by @arnav in commit: b78d0b3

Test Plan:
1. Change the user's Full name field and submit. Check that the success status message appears on top.
2. Try changing the user's Full name field and the password, and confirm that two API
requests are made. Confirm that the success status message again appears on top. Logout and try logging in with the new password to confirm it works.
3. Try changing only the password and confirm that the success status message appears on top.

Reviewers: ram, wesley, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: kannan, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D8624
ngov17 pushed a commit to ngov17/yugabyte-db that referenced this issue Jun 26, 2020
…file page.

Summary:
Fix password reset flow as a separate API call when user changes the UserProfileForm.
Compare the values on submit to the initial values and determine if a profile and/or a password
change occurred.

The new password submit endpoint was implemented by @arnav in commit: yugabyte@b78d0b3

Test Plan:
1. Change the user's Full name field and submit. Check that the success status message appears on top.
2. Try changing the user's Full name field and the password, and confirm that two API
requests are made. Confirm that the success status message again appears on top. Logout and try logging in with the new password to confirm it works.
3. Try changing only the password and confirm that the success status message appears on top.

Reviewers: ram, wesley, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: kannan, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D8624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui All issues relating to UI/UX priority/high High Priority
Projects
None yet
Development

No branches or pull requests

2 participants