Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Unable to reset user password #3909

Closed
ramkumarvs opened this issue Mar 10, 2020 · 1 comment
Closed

[Platform] Unable to reset user password #3909

ramkumarvs opened this issue Mar 10, 2020 · 1 comment
Assignees
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX

Comments

@ramkumarvs
Copy link
Contributor

Currently on master, there seem to be some regression when trying to reset the password.

@ramkumarvs ramkumarvs added the area/ui All issues relating to UI/UX label Mar 10, 2020
@ramkumarvs ramkumarvs self-assigned this Mar 10, 2020
@ajcaldera1
Copy link
Contributor

Bump

@schoudhury schoudhury added the area/platform Yugabyte Platform label Jun 1, 2020
@rkarthik007 rkarthik007 assigned andrewc-dev and unassigned WesleyW and ramkumarvs Jun 1, 2020
andrewc-dev pushed a commit that referenced this issue Jun 5, 2020
Summary:
Fix password reset flow as a separate API call when user changes the UserProfileForm.
Compare the values on submit to the initial values and determine if a profile and/or a password
change occurred.

The new password submit endpoint was implemented by @arnav in commit: b78d0b3

Test Plan:
1. Change the user's Full name field and submit. Check that the success status message appears on top.
2. Try changing the user's Full name field and the password, and confirm that two API
requests are made. Confirm that the success status message again appears on top. Logout and try logging in with the new password to confirm it works.
3. Try changing only the password and confirm that the success status message appears on top.

Reviewers: ram, wesley, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: kannan, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D8624
andrewc-dev pushed a commit that referenced this issue Jun 8, 2020
Summary:
Fix password reset flow as a separate API call when user changes the UserProfileForm.
Compare the values on submit to the initial values and determine if a profile and/or a password
change occurred.

The new password submit endpoint was implemented by @arnav in commit: b78d0b3

Test Plan:
1. Change the user's Full name field and submit. Check that the success status message appears on top.
2. Try changing the user's Full name field and the password, and confirm that two API
requests are made. Confirm that the success status message again appears on top. Logout and try logging in with the new password to confirm it works.
3. Try changing only the password and confirm that the success status message appears on top.

Reviewers: ram, wesley, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: kannan, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D8624
ngov17 pushed a commit to ngov17/yugabyte-db that referenced this issue Jun 26, 2020
…file page.

Summary:
Fix password reset flow as a separate API call when user changes the UserProfileForm.
Compare the values on submit to the initial values and determine if a profile and/or a password
change occurred.

The new password submit endpoint was implemented by @arnav in commit: yugabyte@b78d0b3

Test Plan:
1. Change the user's Full name field and submit. Check that the success status message appears on top.
2. Try changing the user's Full name field and the password, and confirm that two API
requests are made. Confirm that the success status message again appears on top. Logout and try logging in with the new password to confirm it works.
3. Try changing only the password and confirm that the success status message appears on top.

Reviewers: ram, wesley, arnav, sshevchenko

Reviewed By: sshevchenko

Subscribers: kannan, rao, ui

Differential Revision: https://phabricator.dev.yugabyte.com/D8624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform Yugabyte Platform area/ui All issues relating to UI/UX
Projects
None yet
Development

No branches or pull requests

5 participants