Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starboard: roll up the remaining unittest targets #5127

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

yell0wd0g
Copy link
Contributor

@yell0wd0g yell0wd0g commented Mar 20, 2025

This PR continues the work of #4831 and rolls up all other targets I could find that looked like unit tests into starboard_unittests.

It also gets the changes of #5031, so that the aspect of starboard/BUILD.gn is closer to the final state.

With this I see

[==========] 2106 tests from 57 test suites ran. (535744 ms total)
[  PASSED  ] 1818 tests.
[  SKIPPED ] 288 tests, listed below:

  YOU HAVE 1 DISABLED TEST

(the disabled test was from before, the skipped ones are new, see further below).

Other topics:

  • media_util_test.cc needed operator== on SbMediaColorMetadatas, so I added it as extern.
  • VideoDecoderTests/...beneath_the_canopy_137_avc... were failing because PlayerComponentsFactory couldn't load libopenh264.so. My debian did not have that link (only libopenh264.so.7), when I added it it started working. Something to watch out for in bots.
  • Similarly PlayerComponentsTest needed the libfdk-aac pacakge, with a vanilla link that I had to do by hand.
  • E-AC-3 and AC-03 related audio tests refer to Dolby Vision, for which I could not find an opensource library (plugin for ffmpeg); this CL adds code to SKIP them on Linux bots.
  • //starboard/raspi/shared/:starboard_platform_tests target was empty, this CL removes it.

Bug: b/384819454

@yell0wd0g yell0wd0g force-pushed the b_384819454__3__roll_more_starboard_unittests branch from ae047d9 to 4f2b41b Compare March 21, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant