starboard: roll up the remaining unittest targets #5127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the work of #4831 and rolls up all other targets I could find that looked like unit tests into
starboard_unittests
.It also gets the changes of #5031, so that the aspect of starboard/BUILD.gn is closer to the final state.
With this I see
(the disabled test was from before, the skipped ones are new, see further below).
Other topics:
media_util_test.cc
neededoperator==
onSbMediaColorMetadata
s, so I added it as extern.VideoDecoderTests/...beneath_the_canopy_137_avc...
were failing becausePlayerComponentsFactory
couldn't loadlibopenh264.so
. My debian did not have that link (onlylibopenh264.so.7
), when I added it it started working. Something to watch out for in bots.PlayerComponentsTest
needed thelibfdk-aac
pacakge, with a vanilla link that I had to do by hand.//starboard/raspi/shared/:starboard_platform_tests
target was empty, this CL removes it.Bug: b/384819454