starboard: Create starboard_unittest_wrapper #5031
Open
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxve
reviewed
Mar 7, 2025
andrewsavage1
approved these changes
Mar 17, 2025
Hmmm I don't see |
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Mar 20, 2025
yell0wd0g
added a commit
to yell0wd0g/cobalt
that referenced
this pull request
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #4831 which landed with a TODO to move the newly introduced
starboard_unittestsinto aif (current_toolchain == starboard_toolchain)block, and let external users depend on astarboard_unittests_wrapperinstead.#4831 landed unintendedly, so this CL follows up quickly; CI is likely to fail while #4464 is being worked on.
Bug: b/384819454