Include symbols into install/lib/libcobalt.so #1857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ |
Codecov Report
@@ Coverage Diff @@
## main #1857 +/- ##
=======================================
Coverage 57.75% 57.76%
=======================================
Files 1915 1915
Lines 95108 95108
=======================================
+ Hits 54929 54935 +6
+ Misses 40179 40173 -6 |
y4vor
reviewed
Oct 27, 2023
hlwarriner
reviewed
Oct 30, 2023
maxz-lab
force-pushed
the
maxz-lab-sb16-symbols
branch
from
8b6bebb
to
59f93f7
Compare
y4vor
approved these changes
Oct 30, 2023
TyHolc
approved these changes
Oct 30, 2023
To speed up the SB16 development process, include some symbols (-gline-tables-only) into install/lib/libcobalt.so. This change affects devel builds only. b/307760111
maxz-lab
force-pushed
the
maxz-lab-sb16-symbols
branch
from
59f93f7
to
33512c8
Compare
hlwarriner
approved these changes
Oct 31, 2023
hlwarriner
added a commit
to hlwarriner/cobalt
that referenced
this pull request
Nov 1, 2023
This change was made a while ago, in youtube#117, but then reverted in youtube#500. I think the original change was reverted either accidentally or to get symbols included in gtest binaries. But if it was reverted in order to get symbols in gtest binaraies, that should now be covered by youtube#1857. b/268244534 b/192672173 Change-Id: Iacc32af77c1a192136863872f361de4a50d566e0
hlwarriner
added a commit
that referenced
this pull request
Nov 6, 2023
This change was made a while ago, in #117, but then reverted in #500. I think the original change was reverted either accidentally or to get symbols included in gtest binaries. But if it was reverted in order to get symbols in gtest binaraies, that should now be covered by #1857. b/268244534 b/192672173 Change-Id: Iacc32af77c1a192136863872f361de4a50d566e0
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Nov 6, 2023
This change was made a while ago, in #117, but then reverted in #500. I think the original change was reverted either accidentally or to get symbols included in gtest binaries. But if it was reverted in order to get symbols in gtest binaraies, that should now be covered by #1857. b/268244534 b/192672173 Change-Id: Iacc32af77c1a192136863872f361de4a50d566e0 (cherry picked from commit 2277260)
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
To speed up the SB16 development process, include some symbols (-gline-tables-only) into install/lib/libcobalt.so. This change affects devel and debug builds only. b/307760111
Rongo-JL
pushed a commit
to Rongo-JL/cobalt
that referenced
this pull request
Dec 19, 2023
This change was made a while ago, in youtube#117, but then reverted in youtube#500. I think the original change was reverted either accidentally or to get symbols included in gtest binaries. But if it was reverted in order to get symbols in gtest binaraies, that should now be covered by youtube#1857. b/268244534 b/192672173 Change-Id: Iacc32af77c1a192136863872f361de4a50d566e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To speed up the SB16 development process, include some symbols (-gline-tables-only) into install/lib/libcobalt.so.
This change affects devel and debug builds only.
b/307760111