Skip to content

Commit

Permalink
Use installable lib as Evergreen loader's data dep (youtube#1889)
Browse files Browse the repository at this point in the history
This change was made a while ago, in
youtube#117, but then reverted in
youtube#500.

I think the original change was reverted either accidentally or to get
symbols included in gtest binaries. But if it was reverted in order to
get symbols in gtest binaraies, that should now be covered by
youtube#1857.

b/268244534
b/192672173

Change-Id: Iacc32af77c1a192136863872f361de4a50d566e0
  • Loading branch information
hlwarriner authored and Rongo-JL committed Dec 19, 2023
1 parent 13f8b87 commit 2060130
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion starboard/build/config/BUILDCONFIG.gn
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ template("evergreen_loader") {
copy("copy_loader_app_lib${original_target_name}") {
install_content = true
if (target_cpu == "arm" && arm_float_abi == "softfp") {
sources = [ "$root_out_dir/../evergreen-$target_cpu-${arm_float_abi}_$build_type/lib${original_target_name}.so" ]
sources = [ "$root_out_dir/../evergreen-$target_cpu-${arm_float_abi}_$build_type/install/lib/lib${original_target_name}.so" ]
} else if (target_cpu == "arm64") {
sources = [ "$root_out_dir/../evergreen-$target_cpu_$build_type/install/lib/libcobalt.so" ]
}
Expand Down

0 comments on commit 2060130

Please sign in to comment.