Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProseMirror example and Tree codes #686

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Refactor ProseMirror example and Tree codes #686

merged 5 commits into from
Nov 20, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Nov 7, 2023

What this PR does / why we need it?

Refactor ProseMirror example and Tree codes

  • Refactor ProseMirror example

This commit improves the ProseMirror example by removing redundant and
unused code in both HTML and CSS, resulting in cleaner and simpler.

  • Eliminate Tree.Split
    Since Tree.Split is invoked during content editing, this commit removes
    the separate Tree.Split, streamlining the codebase.

  • Enhance Tree tests and uncomment basic text split test
    In preparation for adding a split parameter to Tree.Edit, this commit
    simplifies the Tree.Edit interface for better representation in a line.

Any background context you want to provide?

What are the relevant tickets?

Address yorkie-team/yorkie#662

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (859c019) 67.94% compared to head (81a4a7a) 68.03%.

❗ Current head 81a4a7a differs from pull request most recent head 4251c59. Consider uploading reports for the commit 4251c59 to get more accurate results

Files Patch % Lines
src/document/crdt/tree.ts 92.85% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #686      +/-   ##
==========================================
+ Coverage   67.94%   68.03%   +0.08%     
==========================================
  Files          58       58              
  Lines        8783     8773      -10     
  Branches      795      794       -1     
==========================================
+ Hits         5968     5969       +1     
+ Misses       2555     2546       -9     
+ Partials      260      258       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins force-pushed the tree-split branch 5 times, most recently from 1b0dc1f to b4c0e1d Compare November 8, 2023 11:24
@hackerwins hackerwins force-pushed the tree-split branch 2 times, most recently from 056f549 to f276a82 Compare November 16, 2023 06:21
@hackerwins hackerwins changed the title Implement split feature in Tree.Edit Refactor ProseMirror example and Tree codes Nov 20, 2023
@hackerwins hackerwins merged commit 0a5e977 into main Nov 20, 2023
1 check passed
@hackerwins hackerwins deleted the tree-split branch November 20, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant