Reflecting Changes in Tree from 0.4.8 to 0.4.12 #147
Conversation
| @@ -22,7 +22,7 @@ services: | |||
| extra_hosts: | |||
| - "host.docker.internal:host-gateway" | |||
| yorkie: | |||
| image: 'yorkieteam/yorkie:0.4.8' | |||
| image: 'yorkieteam/yorkie:0.4.10' | |||
There was a problem hiding this comment.
@hackerwins activateClientRequest returns the following error for the server version 0.4.11 and above:
io.grpc.StatusException: UNAVAILABLE: upstream connect error or disconnect/reset before headers. reset reason: connection termination
There was a problem hiding this comment.
I've updated the protobuf models to the latest version(8454812), but the issue still persists.
It's working fine with the real server(api.yorkie.dev, 443), so I'll keep the CI local server version at 0.4.10 until the issue is resolved
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
+ Coverage 78.33% 80.96% +2.62%
==========================================
Files 63 63
Lines 3721 3840 +119
Branches 582 601 +19
==========================================
+ Hits 2915 3109 +194
+ Misses 500 415 -85
- Partials 306 316 +10 ☔ View full report in Codecov by Sentry. |
| @@ -121,7 +121,7 @@ public class Document(public val key: Key, private val options: Options = Option | |||
| val proxy = JsonObject(context, clone.root.rootObject) | |||
| updater.invoke( | |||
| proxy, | |||
| Presence(context, clone.presences[changeID.actor] ?: emptyMap()), | |||
| Presence(context, clone.presences.getOrDefault(changeID.actor, emptyMap())), | |||
There was a problem hiding this comment.
why not just use .orEmpty()
| } | ||
|
|
||
| /** | ||
| * Edits the given [range] with the given [contents]. | ||
| * This method uses indexes instead of a pair of [TreePos] for testing. | ||
| */ | ||
| fun editByIndex( | ||
| @VisibleForTesting | ||
| fun editT( |
There was a problem hiding this comment.
what is the meaning of editT?
There was a problem hiding this comment.
I think T stands for Test since the function is only for testing.
the name editT was a bit confusing to me as well, and the function isn't that essential, so I just removed it in b5998fd.
it works the same though.
(cc. @hackerwins )
What this PR does / why we need it?
This PR covers up all the changes in Tree from v0.4.8 to v.0.4.12 except for
split()andmerge().I've also updated minSdkVersion to 24, but I'll roll back to 23 if there are any potential issues
Any background context you want to provide?
What are the relevant tickets?
Fixes #
Checklist