Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix concurrent modification on gc #42

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

skhugh
Copy link
Contributor

@skhugh skhugh commented Nov 2, 2022

What this PR does / why we need it?

fix concurrent modification on gc.
I used iterator for textWithGarbageSetByCreatedAt, but snapshot for removedElementSetByCreatedAt because gc flow is quite complex here.

Any background context you want to provide?

What are the relevant tickets?

Fixes #

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@skhugh skhugh requested review from 7hong13 and hackerwins November 2, 2022 13:46
@skhugh skhugh self-assigned this Nov 2, 2022
@skhugh skhugh requested a review from daeyounglnc November 2, 2022 13:47
@skhugh skhugh mentioned this pull request Nov 2, 2022
2 tasks
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #42 (753dc4d) into main (e18bfe2) will increase coverage by 0.44%.
The diff coverage is 55.55%.

@@             Coverage Diff              @@
##               main      #42      +/-   ##
============================================
+ Coverage     75.65%   76.09%   +0.44%     
- Complexity      369      371       +2     
============================================
  Files            43       43              
  Lines          1614     1615       +1     
  Branches        230      231       +1     
============================================
+ Hits           1221     1229       +8     
+ Misses          259      249      -10     
- Partials        134      137       +3     
Impacted Files Coverage Δ
...c/main/kotlin/dev/yorkie/document/crdt/CrdtRoot.kt 58.53% <55.55%> (+9.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hackerwins hackerwins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 👍

@hackerwins hackerwins merged commit 0d98637 into main Nov 3, 2022
@hackerwins hackerwins deleted the concurrent_modification branch November 3, 2022 04:56
hackerwins pushed a commit that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants