Sample kanban board app implementation #39
Conversation
Codecov Report
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 78.94% 78.59% -0.36%
==========================================
Files 44 44
Lines 1724 1733 +9
Branches 250 250
==========================================
+ Hits 1361 1362 +1
- Misses 224 232 +8
Partials 139 139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
||
| class KanbanActivity : AppCompatActivity() { | ||
| private lateinit var binding: ActivityKanbanBinding | ||
| private val viewModel: KanbanViewModel by lazy { |
There was a problem hiding this comment.
we can use viewModels extension here :)
| private val itemsListener: (ViewGroup, Pair<String, List<String>>) -> Unit, | ||
| private val itemAddListener: (ViewGroup, String, String) -> Unit, | ||
| private val cardDeleteListener: (String) -> Unit, | ||
| ) : RecyclerView.Adapter<KanbanCardAdapter.KanbanCardViewHolder>() { |
There was a problem hiding this comment.
if we are not going to use Compose... we should at least use ListAdapter.
| @@ -196,6 +196,13 @@ public class Document private constructor( | |||
| return root.toJson() | |||
| } | |||
|
|
|||
| public fun getRoot(): JsonObject { | |||
| ensureClone() | |||
| val clone = requireNotNull(clone) | |||
There was a problem hiding this comment.
I made ensureClone to return the clone instance, so we can change to val clone = ensureClone()
| ensureClone() | ||
| val clone = requireNotNull(clone) | ||
| val context = ChangeContext(changeID.next(), clone, null) | ||
| return JsonObject(context, clone.rootObject) |
There was a problem hiding this comment.
this feels kinda weird to me :(
we are returning a mutable JsonObject but changes will have no effect...
maybe we should consider creating a immutable read-only Json elements for this use-case. 🤔
| } | ||
| } catch (e: Exception) { | ||
| // TODO(7hong): handle ConcurrentModificationException |
There was a problem hiding this comment.
modifying a collection should not happen inside a loop.
we should use iterator.. or loop a snapshot of a collection.
| import androidx.compose.ui.unit.dp | ||
| import androidx.compose.ui.unit.sp | ||
|
|
||
| data class KanbanColumn( |
There was a problem hiding this comment.
maybe we need new interface to use these (non-crdt) custom classes easily in the document.
since Android SDK doesn't reveal id of the JsonObject to public, I'm not sure how to get particular JsonObject in the document right now... (ex. when adding a new card to the particular column)
| data class KanbanColumn( | ||
| val title: String, | ||
| val cards: List<Card>, | ||
| var id: TimeTicket = TimeTicket.InitialTimeTicket, |
There was a problem hiding this comment.
using mutable properties should be avoided when we are using Compose.
What this PR does / why we need it?
Sample Kanban board implementation.
result:
2022-11-08.2.45.20.mov
Any background context you want to provide?
I changed
TimeTicketas public and used it as a key forJsonArray, but it is just temporary try to sync with other SDKs.we should change the structure later to improve its usability.
What are the relevant tickets?
Fixes #
Checklist