Replace remaining custom deep cloning with 'structuredClone' (WordPre…

…ss#67707) * Replace remaining custom deep cloning with 'structuredClone' * Polyfill structuredClone for jsdom Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
yogeshbhutkar · Dec 18, 2024 · 7d3fa75 · 7d3fa75
1 parent 722ba4f
commit 7d3fa75
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/global-styles/use-global-styles-output.js b/packages/block-editor/src/components/global-styles/use-global-styles-output.js
@@ -624,7 +624,7 @@ function pickStyleKeys( treeToPickFrom ) {
 	// clone the style objects so that `getFeatureDeclarations` can remove consumed keys from it
 	const clonedEntries = pickedEntries.map( ( [ key, style ] ) => [
 		key,
-		JSON.parse( JSON.stringify( style ) ),
+		structuredClone( style ),
 	] );
 	return Object.fromEntries( clonedEntries );
 }

diff --git a/packages/block-editor/src/hooks/style.js b/packages/block-editor/src/hooks/style.js
@@ -245,7 +245,7 @@ export function omitStyle( style, paths, preserveReference = false ) {
 
 	let newStyle = style;
 	if ( ! preserveReference ) {
-		newStyle = JSON.parse( JSON.stringify( style ) );
+		newStyle = structuredClone( style );
 	}
 
 	if ( ! Array.isArray( paths ) ) {

diff --git a/test/unit/config/global-mocks.js b/test/unit/config/global-mocks.js
@@ -3,6 +3,7 @@
  */
 import { TextDecoder, TextEncoder } from 'node:util';
 import { Blob as BlobPolyfill, File as FilePolyfill } from 'node:buffer';
+import 'core-js/stable/structured-clone';
 
 jest.mock( '@wordpress/compose', () => {
 	return {
@@ -49,3 +50,6 @@ if ( ! global.TextEncoder ) {
 // Override jsdom built-ins with native node implementation.
 global.Blob = BlobPolyfill;
 global.File = FilePolyfill;
+
+// Polyfill structuredClone for jsdom.
+global.structuredClone = structuredClone;