Replace remaining custom deep cloning with 'structuredClone' #67707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -8 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 4fec584. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12211324308
|
|
The Should I patch it in the tests? That might mean we get different behavior with actual code and tests. |
|
Could you add it to |
Can we do that without overriding the |
How come, I think we use the So you can't just use the underlying Node.js modules like this (please correct me if I'm missing something). An easy alternative would be to import the core-js polyfill in import 'core-js/stable/structured-clone';and then you will be able to expose that as a jsdom global: global.structuredClone = structuredClone; |
jsnajdr
reviewed
Dec 9, 2024
| @@ -49,3 +50,6 @@ if ( ! global.TextEncoder ) { | |||
| // Override jsdom built-ins with native node implementation. | |||
| global.Blob = BlobPolyfill; | |||
| global.File = FilePolyfill; | |||
|
|
|||
| // Polyfill structuredClone for jsdom. | |||
| global.structuredClone = structuredClone; | |||
There was a problem hiding this comment.
@tyxla writes:
So you can't just use the underlying Node.js modules like this (please correct me if I'm missing something).
The jsdom environment creates a new global object for the environment, but it still runs in Node.js. If native structuredClone is available in Node.js, then you should be able to "forward" it from the Node.js global to the jsdom global.
Could the global.structuredClone = structuredClone assignment work without importing the CoreJS polyfill? If the structuredClone reference uses the Node.js globalThis, it should work.
There was a problem hiding this comment.
I tried that initially, but unfortunately, it doesn't work.
There was a problem hiding this comment.
OK then let's do the CoreJS version.
jsnajdr
approved these changes
Dec 9, 2024
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…ss#67707) * Replace remaining custom deep cloning with 'structuredClone' * Polyfill structuredClone for jsdom Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Mamaduka
added a commit
that referenced
this pull request
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This is similar to #64203.
PR updates remaining places in editors' codebase to use
structuredCloneinstead ofJSON.parse( JSON.stringify( value ) )hack.Testing Instructions
omitStylesunit tests are passing.Testing Instructions for Keyboard
Same.