Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shortcut for Nested + Each #279

Merged
merged 33 commits into from
Aug 20, 2022
Merged

Add shortcut for Nested + Each #279

merged 33 commits into from
Aug 20, 2022

Conversation

arogachev
Copy link
Contributor

@arogachev arogachev commented Aug 1, 2022 •
edited by vjik
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #195, #159, #280

⚠️ Required:

TODO list:

  • Update README.
  • Configuration of dynamically generated Nested and Each rules.
  • Check and handle edge cases.
  • Escape separator and shortcut back in Result::getErrorMessagesIndexedByPath()?
  • A proper Psalm fix?

@arogachev arogachev changed the title Restore test for nested + each combination Add shortcut for Nested + Each Aug 1, 2022
@arogachev arogachev self-assigned this Aug 1, 2022
@arogachev arogachev added type:feature New feature type:enhancement Enhancement and removed type:feature New feature labels Aug 1, 2022
@samdark samdark mentioned this pull request Aug 6, 2022
Closed
This was linked to issues Aug 6, 2022
Add custom attribute separator support in the Nested rule #159
Closed
Add shortcut for Nested + Each #195
Closed
@arogachev arogachev changed the title Add shortcut for Nested + Each Add shortcut for Nested + Each, option to escape delimiter and shortcut Aug 8, 2022
@arogachev arogachev marked this pull request as ready for review August 8, 2022 07:38
@arogachev arogachev requested a review from a team August 8, 2022 07:38
@arogachev arogachev linked an issue Aug 8, 2022 that may be closed by this pull request
Regression of error message for Each rule #280
Closed
@arogachev arogachev changed the title Add shortcut for Nested + Each, option to escape delimiter and shortcut Add shortcut for Nested + Each Aug 8, 2022
@samdark samdark added this to the 1.0.0 milestone Aug 17, 2022
@vjik vjik requested a review from a team August 19, 2022 19:39
@vjik vjik added the status:code review The pull request needs review. label Aug 19, 2022
@vjik vjik merged commit 14d3e85 into master Aug 20, 2022
@vjik vjik deleted the 195-nested-each-shortcut branch August 20, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees

@arogachev arogachev

Labels
status:code review The pull request needs review. type:enhancement Enhancement
Projects
None yet
Milestone
1.0.0
4 participants
@arogachev @samdark @vjik @StyleCIBot