Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for escaping delimiter while parsing path #111

Merged
merged 35 commits into from
Aug 19, 2022
Merged

Add support for escaping delimiter while parsing path #111

merged 35 commits into from
Aug 19, 2022

Conversation

arogachev
Copy link
Contributor

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues

yiisoft/validator#159 (comment)

@arogachev arogachev requested a review from a team August 3, 2022 10:01
@arogachev arogachev self-assigned this Aug 3, 2022
@arogachev arogachev added the type:enhancement Enhancement label Aug 3, 2022
vjik
vjik requested changes Aug 3, 2022
View reviewed changes
tests/ArrayHelper/ArrayHelperTest.php Outdated Show resolved Hide resolved
@arogachev arogachev marked this pull request as draft August 4, 2022 11:13
@arogachev arogachev marked this pull request as ready for review August 4, 2022 11:57
@arogachev arogachev requested a review from a team August 4, 2022 11:57
@arogachev arogachev marked this pull request as draft August 4, 2022 12:39
@arogachev arogachev marked this pull request as ready for review August 8, 2022 05:53
@arogachev arogachev mentioned this pull request Aug 8, 2022
Merged
5 tasks
samdark
samdark reviewed Aug 9, 2022
View reviewed changes
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
samdark
samdark requested changes Aug 9, 2022
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine but a few corrections are needed.

@arogachev arogachev requested a review from a team August 10, 2022 04:46
@arogachev arogachev mentioned this pull request Aug 10, 2022
Closed
samdark
samdark reviewed Aug 10, 2022
View reviewed changes
src/ArrayHelper.php Outdated Show resolved Hide resolved
vjik
vjik reviewed Aug 11, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
arogachev and others added 3 commits August 15, 2022 12:04
@arogachev @samdark
Fix wording
d4ba76f 
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
@arogachev @vjik
More detailed changelog
c83ddf7 
Co-authored-by: Sergei Predvoditelev <sergey.predvoditelev@gmail.com>
@arogachev
Fix linebreak [skip ci]
d4f5a09
@arogachev arogachev requested a review from a team August 16, 2022 06:13
roxblnfk
roxblnfk reviewed Aug 16, 2022
View reviewed changes
src/ArrayHelper.php Outdated Show resolved Hide resolved
@arogachev arogachev requested a review from a team August 16, 2022 08:10
samdark
samdark reviewed Aug 17, 2022
View reviewed changes
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
src/ArrayHelper.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Outdated Show resolved Hide resolved
vjik
vjik reviewed Aug 18, 2022
View reviewed changes
tests/ArrayHelper/GetValueByPathTest.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Outdated Show resolved Hide resolved
tests/ArrayHelper/ParsePathTest.php Show resolved Hide resolved
@vjik vjik merged commit 7af88eb into master Aug 19, 2022
@vjik vjik deleted the escape-delimiter branch August 19, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roxblnfk roxblnfk roxblnfk left review comments

@vjik vjik vjik requested changes

@samdark samdark samdark approved these changes

Assignees

@arogachev arogachev

Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arogachev @samdark @vjik @roxblnfk @StyleCIBot