Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech Recognition #1487

Merged
merged 5 commits into from
Jul 28, 2021
Merged

Speech Recognition #1487

merged 5 commits into from
Jul 28, 2021

Commits on Jul 23, 2021

  1. Voice Search Icon Reorganization (#1476)

    I reorganized the voice search icon logic to clean things up
    
    I also noticed a bug when both the mic and the listening icon are custom. The styling changes fix that bug
    
    J=none
    TEST=manual
    
    Test that the voice icon works and that all combinations of custom icons works as well
    cea2aj authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    51ae5da View commit details
    Browse the repository at this point in the history
  2. Update listening icon with new animations (#1479)

    Update the listening icon with the new animation from UX
    
    J=SLAP-1442
    TEST=manual
    
    See that the listening icon is animated when in the listening state
    cea2aj authored Jul 23, 2021
    Configuration menu
    Copy the full SHA
    30ff6e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Speech Recognition Functionality (#1480)

    Add speech recognition functionality to the searchbar
    
    This PR includes:
    - Connecting the speech recognizer to the voice search button
    - Adding analytics for clicking on the voice search button which includes not sending the queryId for the voice search analytics
    - Checking that `navigator.mediaDevices` exists so that the search bar will hide on Edge without HTTPs
    - Update the autocomplete component to know when voice search is active. This allows the autocomplete dropdown to appear while voice search is active
    - Add `submitVoiceSearch()` to the search bar so that a search can be made with the VOICE_SEARCH query trigger
    
    J=SLAP-1444
    TEST=manual
    
    Test speech recognition on Chrome, Safari, and Edge. Firefox is not supported. Note: The site must be on HTTPS for Edge to work.
    cea2aj authored Jul 27, 2021
    Configuration menu
    Copy the full SHA
    030bee1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    debddd8 View commit details
    Browse the repository at this point in the history
  3. Resolve merge issue

    cea2aj committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    6db4e12 View commit details
    Browse the repository at this point in the history