Speech Recognition #1487
Merged
Speech Recognition #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I reorganized the voice search icon logic to clean things up I also noticed a bug when both the mic and the listening icon are custom. The styling changes fix that bug J=none TEST=manual Test that the voice icon works and that all combinations of custom icons works as well
Update the listening icon with the new animation from UX J=SLAP-1442 TEST=manual See that the listening icon is animated when in the listening state
Add speech recognition functionality to the searchbar This PR includes: - Connecting the speech recognizer to the voice search button - Adding analytics for clicking on the voice search button which includes not sending the queryId for the voice search analytics - Checking that `navigator.mediaDevices` exists so that the search bar will hide on Edge without HTTPs - Update the autocomplete component to know when voice search is active. This allows the autocomplete dropdown to appear while voice search is active - Add `submitVoiceSearch()` to the search bar so that a search can be made with the VOICE_SEARCH query trigger J=SLAP-1444 TEST=manual Test speech recognition on Chrome, Safari, and Edge. Firefox is not supported. Note: The site must be on HTTPS for Edge to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add speech recognition functionality