merge DA on vertical search feature #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yen-tt
commented
Jul 26, 2021
•
yen-tt
commented
- update core version to 1.3.0-beta.2
- include feature/DirectAnswer-in-Vertical changes
- update core.js file: vertical search set StorageKeys.DIRECT_ANSWERS to loading state at the beginning of the search for opacity styling
* Update SDK to allow DA on vertical search add direct answers to vertical search in sdk core data transformer layer Note: this sdk is using core version 1.3.0-alpha to get vertical search responses with direct answer J=SLAP-1389 TEST=auto and manual Update and run jest tests to see that results are formatted properly. Verify direct answer is fetched properly from answers-core with console log. Launched theme test site using local sdk bundle, performed a vertical search on people's page and can verify that direct answer is present in network response Co-authored-by: Yen Truong <ytruong@yext.com>
oshi97
approved these changes
Jul 27, 2021
oshi97
added a commit
that referenced
this pull request
Aug 24, 2021
### New Features * The SearchBar now supports displaying a loading indicator while a search is running. * The SearchBar also now has support for voice search. * We now support several new languages, including simplified/traditional Chinese and several variants of Arabic. * `universalLimit` config option (#1444) * Session tracking using the browser's session storage (#1452) * `querySource` can now be set at runtime using `ANSWERS.setQuerySource()` (#1464) * Display email validation error in QuestionSubmission (#1505) * Support for DirectAnswers on vertical searches (#1483) * Support providerOptions on the map (#1484) * Create entry points for multi-lang SDK bundles (#1501) ### Speed Improvements * replace IconComponent usages with handlebars partials (#1445) (#1451) (#1458) ### Infrastructure * Change CircleCI node_modules caching strategy to use package-lock.json instead of package.json (#1457) * `canary/latest` assets are now built with i18n support (#1459) * More tests + acceptance testing improvements * Automated publishing for the standalone SearchBar assets (#1529) ### SearchBar-only release notes * The SearchBar now supports displaying a loading indicator while a search is running. * The SearchBar also now has support for voice search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.