build develop with i18n assets #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the theme's test-site can point to canary/latest and have i18n snapshots work. J=SLAP-1423 TEST=manual change develop to this branch's name, see the i18n build run, and only deploy_canary is run (cancelled ahead of time)
tmeyer2115
approved these changes
Jul 7, 2021
cea2aj
added a commit
to yext/answers-hitchhiker-theme
that referenced
this pull request
Jul 13, 2021
Support i18n versions of the answers-search-ui when specifying the develop branch As part of yext/answers-search-ui#1459, develop now builds i18n assets. When specifying develop however, i18n assets weren't being used because the script partial wasn't including the locale in the asset URL. This PR adds support for that. J=none TEST=manual, auto Build the test site and see that the Spanish site correctly loads the Spanish answers assets from canary. Add test coverage
oshi97
added a commit
that referenced
this pull request
Aug 24, 2021
### New Features * The SearchBar now supports displaying a loading indicator while a search is running. * The SearchBar also now has support for voice search. * We now support several new languages, including simplified/traditional Chinese and several variants of Arabic. * `universalLimit` config option (#1444) * Session tracking using the browser's session storage (#1452) * `querySource` can now be set at runtime using `ANSWERS.setQuerySource()` (#1464) * Display email validation error in QuestionSubmission (#1505) * Support for DirectAnswers on vertical searches (#1483) * Support providerOptions on the map (#1484) * Create entry points for multi-lang SDK bundles (#1501) ### Speed Improvements * replace IconComponent usages with handlebars partials (#1445) (#1451) (#1458) ### Infrastructure * Change CircleCI node_modules caching strategy to use package-lock.json instead of package.json (#1457) * `canary/latest` assets are now built with i18n support (#1459) * More tests + acceptance testing improvements * Automated publishing for the standalone SearchBar assets (#1529) ### SearchBar-only release notes * The SearchBar now supports displaying a loading indicator while a search is running. * The SearchBar also now has support for voice search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way the theme's test-site can point to canary/latest
and have i18n snapshots work.
I was wrong, and the i18n build will build ALL the locales, not just the languages.
On the other hand, this still shouldn't cost too much storage since it's only a single branch.
J=SLAP-1423
TEST=manual
use this branch's name (dev/i18n-develop) instead of develop in the circleci config,
see the i18n build run