Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations needed for the Summer Release. #918

Merged
merged 2 commits into from
Aug 16, 2021

Conversation

tmeyer2115
Copy link
Collaborator

This PR adds a number of new language files to the Theme: Chinese (Traditional), Chinese (Simplified),
Russian, Polish, Portugese, Dutch, Arabic, Korean, Swedish, and Hindi. Exisitng language files were
also updated since there were some new strings needing translation.

J=SLAP-1461
TEST=none

This PR adds a number of new language files to the Theme: Chinese (Traditional), Chinese (Simplified),
Russian, Polish, Portugese, Dutch, Arabic, Korean, Swedish, and Hindi. Exisitng language files were
also updated since there were some new strings needing translation.

J=SLAP-1461
TEST=none
@coveralls
Copy link

coveralls commented Aug 13, 2021

Coverage Status

Coverage remained the same at 7.327% when pulling 2eec80e on feature/add-translations into 8256040 on develop.

@@ -0,0 +1,180 @@
msgid ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for my edification, but I thought the locales for chinese were zh_Hans and zh_Hant?

translations/fr.po Outdated Show resolved Hide resolved
@oshi97 oshi97 merged commit 9a0d5a8 into develop Aug 16, 2021
@oshi97 oshi97 deleted the feature/add-translations branch August 16, 2021 15:39
@cea2aj cea2aj mentioned this pull request Aug 24, 2021
cea2aj added a commit that referenced this pull request Aug 24, 2021
### Features
- Support for new languages including Chinese (Traditional), Chinese (Simplified), Russian, Polish, Portuguese, Dutch, Arabic, Korean, Swedish, and Hindi (#918) (#900)
- A loading indicator can now be enabled on the search bar (#875)
- Voice search support (#894)
- Analytics, session tracking, and query source can now be toggled through Runtime Config (#869) (#879)
- Added validation to ensure that parts of global_config and page configs are valid (#888)
- Font preloads are now located in the layouts/preload-fonts.hbs file (#893)
- Global config now includes "sessionTrackingEnabled" and "analyticsEventsEnabled" (#898)
- Added a partial for additional Answers configuration (#903)
- Map pins now support custom label colors (#922)

### Enhancements
- The full-page-map "Search This Area" functionality is better optimized when a user quickly zooms in or out of the map (#861)
- Improved build time during development mode (#865)
- Icons were updated from components to Handlebars partials to improve performance (#874)

### Bugfixes
- When upgrading the theme version, the global config will no longer contain duplicate options which are commented out (#916)
- When upgrading the theme, the tests folders are now removed which improves build performance (#913)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants