add the custom-init-config partial #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I considered adding this in HitchhikerJS, which would give us better error messages if the a Hitchhiker messes up JS syntax. On the other hand Rose asked for a partial, and I'm a little worried about confusing Hitchhikers. On the other hand probably only advanced Hitchhikers will use this. In the future I was thinking jambo could pass a getter for templates and partials into templatedatavalidator, or even the whole HBS instance, so we can easily validate template/partials. J=SLAP-1447 TEST=manual,auto add a custom-init-config in the test site, with functions for onVerticalSearch and onUniversalSearch
tmeyer2115
reviewed
Aug 3, 2021
script/core.hbs
Outdated
| @@ -103,7 +103,8 @@ | |||
| window.iframeLoaded.then(() => { | |||
| {{> script/iframe-messaging}} | |||
| }); | |||
| } | |||
| }, | |||
| ...{{#stripJsComments}}{{> script/custom-init-config }}{{/stripJsComments}} | |||
There was a problem hiding this comment.
Should we wrap all of onReady in this helper?
There was a problem hiding this comment.
I was thinking it wouldn't hurt to let them override onReady if they wanted, but at that point you should probably override core.hbs
script/custom-init-config.js
Outdated
| @@ -0,0 +1,5 @@ | |||
| // This file expects a JS object literal. | |||
There was a problem hiding this comment.
What about naming this additional-answers-config or something like that? It's a small nit, but there is already custom init config in some sense in the form of the userConfig that's passed in.
tmeyer2115
approved these changes
Aug 3, 2021
Merged
cea2aj
added a commit
that referenced
this pull request
Aug 24, 2021
### Features - Support for new languages including Chinese (Traditional), Chinese (Simplified), Russian, Polish, Portuguese, Dutch, Arabic, Korean, Swedish, and Hindi (#918) (#900) - A loading indicator can now be enabled on the search bar (#875) - Voice search support (#894) - Analytics, session tracking, and query source can now be toggled through Runtime Config (#869) (#879) - Added validation to ensure that parts of global_config and page configs are valid (#888) - Font preloads are now located in the layouts/preload-fonts.hbs file (#893) - Global config now includes "sessionTrackingEnabled" and "analyticsEventsEnabled" (#898) - Added a partial for additional Answers configuration (#903) - Map pins now support custom label colors (#922) ### Enhancements - The full-page-map "Search This Area" functionality is better optimized when a user quickly zooms in or out of the map (#861) - Improved build time during development mode (#865) - Icons were updated from components to Handlebars partials to improve performance (#874) ### Bugfixes - When upgrading the theme version, the global config will no longer contain duplicate options which are commented out (#916) - When upgrading the theme, the tests folders are now removed which improves build performance (#913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I considered adding this in HitchhikerJS, which
would give us better error messages if the a Hitchhiker messes
up JS syntax. On the other hand Rose asked for a partial,
and I'm a little worried about confusing Hitchhikers.
In the future I was thinking jambo could pass a getter for
templates and partials into templatedatavalidator, or even
the whole HBS instance, so we can easily validate template/partials.
J=SLAP-1447
TEST=manual
add an additional-answers-config to the test site, with functions for onVerticalSearch
and onUniversalSearch