Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add analytics to RTF link clicks in result cards. #852

Merged
merged 2 commits into from
Jun 28, 2021
Merged

Add analytics to RTF link clicks in result cards. #852

merged 2 commits into from
Jun 28, 2021

Commits on Jun 28, 2021

  1. Add analytics to RTF link clicks in result cards. 

    This PR ensures that for all result cards, when an RTF link is clicked, the
correct `AnalyticsEvent` is fired. This code is largely taken from the SDK's
`CardComponent` class. The only difference is in how some of the event options
are computed.

J=SLAP-
TEST=manual

Tested the following:
    @tmeyer2115
    tmeyer2115 committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    3fd7d4c View commit details
    Browse the repository at this point in the history

  2. Replace DOM references.

    @tmeyer2115
    tmeyer2115 committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    5d08f9a View commit details
    Browse the repository at this point in the history