Add analytics to RTF link clicks in result cards. #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR ensures that for all result cards, when an RTF link is clicked, the correct `AnalyticsEvent` is fired. This code is largely taken from the SDK's `CardComponent` class. The only difference is in how some of the event options are computed. J=SLAP- TEST=manual Tested the following:
oshi97
approved these changes
Jun 28, 2021
Merged
tmeyer2115
added a commit
that referenced
this pull request
Jun 29, 2021
Merged
tmeyer2115
added a commit
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that for all result cards, when an RTF link is clicked, the correct
AnalyticsEventis fired. This code is largely taken from the SDK'sCardComponentclass. The only difference is in how some of the event options are computed.J=SLAP-1403
TEST=manual
Tested the following: