Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual tests for all cards #820

Merged
merged 9 commits into from
Jun 7, 2021
Merged

Visual tests for all cards #820

merged 9 commits into from
Jun 7, 2021

Conversation

cea2aj
Copy link
Member

@cea2aj cea2aj commented Jun 7, 2021

Add visual tests to all of the cards

J=SLAP-1361
TEST=visual

Inspect percy snapshots

Reorganize snapshots to make them simpler

Rather than a homepage snaphshot, we can just use univeral search instead and take separate snapshots for no results. Also switch to the non-multilang financial-professional-location because we want full test coverage on the non-multilang cards.

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Add percy snapshots for field direct answers and for document search direct answers

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Snapshot the faq accordion card

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Snapshot the the product video and image cards

J=SLAP-1361
TEST=visual

Check updated percy snapshots
Snapshot the link-standard card

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Snapshot the professional cards

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Snapshot the job standard card

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Snapshot the menu item card

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
Snapshot the document standard card

J=SLAP-1361
TEST=visual

Check the updated percy snapshots
@coveralls
Copy link

Coverage Status

Coverage remained the same at 5.527% when pulling 887b82a on feature/card-visual-tests into 911d215 on develop.

@cea2aj cea2aj merged commit b6408c5 into develop Jun 7, 2021
@cea2aj cea2aj mentioned this pull request Jun 23, 2021
cea2aj added a commit that referenced this pull request Jun 23, 2021
## Version 1.22.0
### Changes
- Code coverage reports are now generated automatically for the Theme. (#759)
- A number of dependencies were updated in accordance with Dependabot's suggestions. (#780)
- The build time in `Development` mode was reduced significantly. (#782, #829) Build times in 
`Production` mode were also decreased. (#783, #825)
- Two new cards supporting videos were added: `product-prominentvideo` and `multilang-product-prominentvideo`. These cards
work with either YouTube or Vimeo content. (#794)
- The process for formatting hours was made more efficient, resulting in faster renders for cards with hours. (#784)
- Any SDK branch can now be specified in the `global_config.sdkVersion` attribute. (#791)
- Unused CSS was removed from the Theme. (#793, #798)
- To reduce flashing related to the SDK Component lifecycle, placeholder skeletons were added for the `SearchBar` and
`Navigation` components. (#797)
- Additional acceptance tests were added for the `VerticalFullPageMap` and Percy snapshots are now generated for all
cards. (#830, #820)
- Multi-language tests were added for the Theme. (#826)
- The `documentsearch-standard` card now supports rich text featured snippets. (#838)
- A new concept, `RuntimeConfig` was added. This allows configuration, computed at run-time, to be injected into the
Theme and SDK. This new concept enables JWT integrations as well. (#843)
### Bug Fixes
- A number of changes were made to make the Theme's visual regression tests more reliable. (#764, #765, #766, #778)
- Corrected how the CTA URLs for the `menuitem-standard` and `multilang-menuitem-standard` cards are computed. (#787)
- The Google Streetview person icon is now visible when using the `VerticalFullPageMap` layout. (#801)
- The size of the cluster and result pins are now configurable. (#807)
- A double encoding error for `verticalUrl` was fixed. (#836)
- The `Opens At` open status message is now properly translated in all languages. (#834)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants