use express instead of serve-handler for snapshots #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
changed the title
tmeyer2115
approved these changes
May 12, 2021
The issue isn't that our iframe integration is able to handle redirects like that, it's that serve-handler isn't capable of retaining query params after redirects. |
oshi97
added a commit
that referenced
this pull request
May 12, 2021
This pr updates our tests to use express instead of serve-handler. serve (likely due to using serve-handler) currently has a bug where, if any redirects occur, it will lose any query params you had in the url. See: vercel/serve#643 On top of that, serve will automatically redirect urls like /index.html to just /, which breaks our iframe integration for universal. J=SLAP-1313 TEST=auto percy snapshots for universal on iframe are now corrected and show the correct query
oshi97
added a commit
that referenced
this pull request
May 12, 2021
This pr updates our tests to use express instead of serve-handler. serve (likely due to using serve-handler) currently has a bug where, if any redirects occur, it will lose any query params you had in the url. See: vercel/serve#643 On top of that, serve will automatically redirect urls like /index.html to just /, which breaks our iframe integration for universal. J=SLAP-1313 TEST=auto percy snapshots for universal on iframe are now corrected and show the correct query
Merged
cea2aj
added a commit
that referenced
this pull request
Jun 23, 2021
## Version 1.22.0 ### Changes - Code coverage reports are now generated automatically for the Theme. (#759) - A number of dependencies were updated in accordance with Dependabot's suggestions. (#780) - The build time in `Development` mode was reduced significantly. (#782, #829) Build times in `Production` mode were also decreased. (#783, #825) - Two new cards supporting videos were added: `product-prominentvideo` and `multilang-product-prominentvideo`. These cards work with either YouTube or Vimeo content. (#794) - The process for formatting hours was made more efficient, resulting in faster renders for cards with hours. (#784) - Any SDK branch can now be specified in the `global_config.sdkVersion` attribute. (#791) - Unused CSS was removed from the Theme. (#793, #798) - To reduce flashing related to the SDK Component lifecycle, placeholder skeletons were added for the `SearchBar` and `Navigation` components. (#797) - Additional acceptance tests were added for the `VerticalFullPageMap` and Percy snapshots are now generated for all cards. (#830, #820) - Multi-language tests were added for the Theme. (#826) - The `documentsearch-standard` card now supports rich text featured snippets. (#838) - A new concept, `RuntimeConfig` was added. This allows configuration, computed at run-time, to be injected into the Theme and SDK. This new concept enables JWT integrations as well. (#843) ### Bug Fixes - A number of changes were made to make the Theme's visual regression tests more reliable. (#764, #765, #766, #778) - Corrected how the CTA URLs for the `menuitem-standard` and `multilang-menuitem-standard` cards are computed. (#787) - The Google Streetview person icon is now visible when using the `VerticalFullPageMap` layout. (#801) - The size of the cluster and result pins are now configurable. (#807) - A double encoding error for `verticalUrl` was fixed. (#836) - The `Opens At` open status message is now properly translated in all languages. (#834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr updates our tests to use express instead of serve-handler.
serve (likely due to using serve-handler) currently has a bug where,
if any redirects occur, it will lose any query params you had in the url.
See: vercel/serve#643
On top of that, serve will automatically redirect urls like
/index.html to just /, which breaks our iframe integration for universal.
J=SLAP-1313
TEST=auto
percy snapshots for universal on iframe are now corrected and
show the correct query