Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @root. prefix to {{relativePath}} in all cards/dacards templates #516

Merged
merged 1 commit into from
Dec 1, 2020

Commits on Dec 1, 2020

  1. Add @root. prefix to {{relativePath}} in all cards/dacards templates

    Certains cards reference {{relativePath}} inside of
    an inline partial, like a CTA partial (see the standard card)
    Since relativePath is passed into all cards at the root context,
    through the SDK's setState(), all cards will have relativePath
    as part of their root context.
    
    TEST=manual
    
    in the standard card:
    test that I can create a custom card, and add a hardcoded cta
    with an iconUrl pointing to a static asset
    
    test that relative links still work in the standard card cta
    oshi97 committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    782cd4a View commit details
    Browse the repository at this point in the history