Add @root. prefix to {{relativePath}} in all cards/dacards templates
#516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certains cards reference {{relativePath}} inside of
an inline partial, like a CTA partial (see the standard card)
Since relativePath is passed into all cards at the root context,
through the SDK's setState(), all cards will have relativePath
as part of their root context.
TEST=manual
in the standard card:
test that I can create a custom card, and add a hardcoded cta
with an iconUrl pointing to a static asset
test that relative links still work in the standard card cta
oshi97
requested review from
cea2aj,
nanhu95,
tmeyer2115,
alexisgrow and
creotutar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certains cards reference {{relativePath}} inside of
an inline partial, like a CTA partial (see the standard card)
Since relativePath is passed into all cards at the root context,
through the SDK's setState(), all cards will have relativePath
as part of their root context.
TEST=manual
in the standard card:
test that I can create a custom card, and add a hardcoded cta
with an iconUrl pointing to a static asset
test that relative links still work in the standard card cta