-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of the universalLimit
in verticalsToConfig
.
#1021
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
/** | ||
* Generates a default result limit for each vertical on the universal page. The | ||
* default is taken from the vertical's `universalLimit`, specified in the related | ||
* page's VTC. If there is no such `universalLimit`, the back-end default of 10 will | ||
* be used. | ||
* | ||
* @param {Object} pageConfigs - The configurations for each page. | ||
* @returns {Object} The partial of the search configuration related to universal limits. | ||
*/ | ||
module.exports = function getDefaultUniversalLimit(pageConfigs) { | ||
const universalLimit = Object.entries(pageConfigs) | ||
.filter(([pageName, _]) => pageName != 'index') | ||
.reduce((limit, [_, pageConfig]) => { | ||
const verticalKey = pageConfig.verticalKey; | ||
const hasUniversalLimit = | ||
pageConfig.verticalsToConfig && | ||
pageConfig.verticalsToConfig[verticalKey] && | ||
pageConfig.verticalsToConfig[verticalKey].universalLimit; | ||
if (hasUniversalLimit) { | ||
limit[verticalKey] = pageConfig.verticalsToConfig[verticalKey].universalLimit; | ||
} | ||
|
||
return limit; | ||
}, {}); | ||
|
||
return { universalLimit }; | ||
tmeyer2115 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the following code might be slightly simpler if this is just
const universalLimit = ...
but also feels like a personal preference thingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I had something like that initially.
But somehow that syntax routinely caused our Percy snapshot generator to crash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah I don't think optional chaining is supported for all the node versions we support. I was just thinking we coudl rename
hasUniversalLimit
to justuniversalLimit
and then line 20 doesn't need to repeatpageConfig.verticalsToConfig[verticalKey].universalLimit