Fix handling of the universalLimit in verticalsToConfig.
#1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
reviewed
Dec 13, 2021
| .filter(([key, _]) => key != 'index') | ||
| .reduce((limit, [_, config]) => { | ||
| const verticalKey = config.verticalKey; | ||
| const hasUniversalLimit = |
There was a problem hiding this comment.
the following code might be slightly simpler if this is just const universalLimit = ... but also feels like a personal preference thing
There was a problem hiding this comment.
So I had something like that initially.
const universalLimit = blah?.blah?.universalLimit
But somehow that syntax routinely caused our Percy snapshot generator to crash.
There was a problem hiding this comment.
Oh yeah I don't think optional chaining is supported for all the node versions we support. I was just thinking we coudl rename hasUniversalLimit to just universalLimit and then line 20 doesn't need to repeat pageConfig.verticalsToConfig[verticalKey].universalLimit
oshi97
approved these changes
Dec 13, 2021
Merged
tmeyer2115
added a commit
that referenced
this pull request
Dec 14, 2021
### Features - Consumer Authentication support was added for the Sandbox environment. (#996) - The existing `image` formatter was updated to support photos sent from the Streams API. (#998) - Support for Direct Answers on Vertical was added to the `vertical-standard` template. It is commented out by default. (#994) ### Changes - To better support Consumer Authentication, the `AnswersExperience.init()` method can be called on `Document` load. (#995) - The default `universalLimit` for all Vertical page configs was updated to 4. (#1010, #1021) ### Bugfixes - Ensured that in all page templates, the `SpellCheck` appears above the `ResultsCount`. (#1011, #1017) - In the `highlightedField` formatter, any HTML tag that appears in the text, that is not `<mark>` or `</mark>`, is now escaped. (#1012) - Font pre-loads on Multi-lang sites now work correctly. (#1018) - A new CSS variable was added: `--yxt-filter-options-option-label-line-height`. This variable, when kept in proper proportion to `--yxt-filters-and-sorts-font-size`, will ensure the scroll bar does not erroneously appear for filter options. (#1015, #1019)
Merged
tmeyer2115
added a commit
that referenced
this pull request
Jan 11, 2022
### Features - Consumer Authentication support was added for the Sandbox environment. (#996) - The existing `image` formatter was updated to support photos sent from the Streams API. (#998) - Support for Direct Answers on Vertical was added to the `vertical-standard` template. It is commented out by default. (#994) ### Changes - To better support Consumer Authentication, the `AnswersExperience.init()` method can be called on `Document` load. (#995) - The default `universalLimit` for all Vertical page configs was updated to 4. (#1010, #1021) ### Bugfixes - Ensured that in all page templates, the `SpellCheck` appears above the `ResultsCount`. (#1011, #1017) - In the `highlightedField` formatter, any HTML tag that appears in the text, that is not `<mark>` or `</mark>`, is now escaped. (#1012) - Font pre-loads on Multi-lang sites now work correctly. (#1018) - A new CSS variable was added: `--yxt-filter-options-option-label-line-height`. This variable, when kept in proper proportion to `--yxt-filters-and-sorts-font-size`, will ensure the scroll bar does not erroneously appear for filter options. (#1015, #1019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a
universalLimitwere specified for a vertical, we would perform client-side filtering. Instead, we should be creating asearch.universalLimitobject and passing that toANSWERS.init. Not only does this remove responsibility from the front-end, but it allows the HH to display more than 10 results per vertical on the Universal page.This PR adds a
getDefaultUniversalLimithelper that iterates through the vertical page configs and uses theverticalsToConfig.universalLimitsto build asearch.universalLimit.J=SLAP-1749
TEST=manual
Tested the following scenarios and verified correct behavior in each:
universalLimitvalues are set and there is no limit specified in theglobal_configorpageSettings.universalLimitvalues are set, but not others. There is no universal limit in theglobal_configorpageSettings.universalLimitvalues are set, but a universal limit is also present in theglobal_config.