#692 And/Or javadoc #817

Vatavuk · 2018-05-04T18:45:51Z

Expanded javadoc for And/Or/AndInThreads for #692

I've updated And and Or javadoc and added a link to AndInThreads which refers to And javadoc examples.

0crat · 2018-05-04T18:47:35Z

Job #817 is now in scope, role is REV

0crat · 2018-05-04T18:51:43Z

This pull request #817 is assigned to @krzyk /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

codecov-io · 2018-05-04T18:53:57Z

Codecov Report

Merging #817 into master will increase coverage by 0.65%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #817      +/-   ##
============================================
+ Coverage     83.58%   84.24%   +0.65%     
- Complexity     1321     1363      +42     
============================================
  Files           240      248       +8     
  Lines          3589     3681      +92     
  Branches        210      214       +4     
============================================
+ Hits           3000     3101     +101     
+ Misses          542      532      -10     
- Partials         47       48       +1

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/scalar/AndInThreads.java	`85.41% <ø> (ø)`	`18 <0> (ø)`	⬇️
src/main/java/org/cactoos/scalar/Or.java	`80% <ø> (ø)`	`12 <0> (ø)`	⬇️
src/main/java/org/cactoos/scalar/And.java	`90.47% <ø> (ø)`	`9 <0> (ø)`	⬇️
...c/main/java/org/cactoos/func/FuncWithFallback.java	`80% <0%> (ø)`	`3% <0%> (ø)`	⬇️
src/main/java/org/cactoos/iterable/Skipped.java
src/main/java/org/cactoos/iterator/Skipped.java
src/main/java/org/cactoos/collection/Skipped.java
src/main/java/org/cactoos/collection/TailOf.java	`100% <0%> (ø)`	`3% <0%> (?)`
src/main/java/org/cactoos/iterator/TailOf.java	`100% <0%> (ø)`	`3% <0%> (?)`
src/main/java/org/cactoos/scalar/Equality.java	`100% <0%> (ø)`	`8% <0%> (?)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced96f1...f774130. Read the comment docs.

krzyk

@Vatavuk please see my comment

krzyk · 2018-05-04T19:19:53Z

src/main/java/org/cactoos/scalar/Or.java

+ *
+ * <pre>
+ * new Or(
+ *    new ProcOf<>(input -> System.out.printf("\'%s\' ", input) ),


@Vatavuk You can't use < or > inside javadoc without some kind of escaping, either < and > or preferably replace the <pre>...</pre> with {@code ...}

Vatavuk · 2018-05-04T19:43:30Z

@krzyk fixed in abf8ec8

krzyk

@Vatavuk almost there :), please see my 2 comments

krzyk · 2018-05-04T19:52:22Z

src/main/java/org/cactoos/scalar/Or.java

+ * {@link java.util.stream.Stream#forEach(java.util.function.Consumer)}
+ * works:</p>
+ *
+ * <pre>


@Vatavuk pre now should be removed ({@code } already uses code font)

krzyk · 2018-05-04T19:52:46Z

src/main/java/org/cactoos/scalar/Or.java

+ * <p>This class could be also used for matching multiple boolean
+ * expressions:</p>
+ *
+ * <pre>


@Vatavuk and here also, <pre></pre> should be removed

Vatavuk · 2018-05-04T19:56:09Z

@krzyk fixed in ee45ae1

krzyk

@Vatavuk looks good

krzyk · 2018-05-04T20:00:41Z

@llorllale ready to merge

Vatavuk · 2018-05-06T08:45:24Z

@llorllale ping

llorllale · 2018-05-06T12:56:19Z

src/main/java/org/cactoos/scalar/And.java

+ *            // the result of this operation is always true
+ * }
+ *
+ * <p>This class could be also used for matching multiple boolean


@Vatavuk could you also please add a note somewhere that And performs a short-circuit evaluation?

llorllale · 2018-05-06T12:57:41Z

src/main/java/org/cactoos/scalar/Or.java

+ *            // the result of this operation is always false
+ * }
+ *
+ * <p>This class could be also used for matching multiple boolean


@Vatavuk could you also please add a note somewhere that Or performs a short-circuit evaluation?

llorllale · 2018-05-06T12:58:18Z

@Vatavuk two minor observations and we're good, see above

Vatavuk · 2018-05-06T13:14:50Z

@llorllale fixed in f774130

llorllale · 2018-05-06T13:31:00Z

@rultor merge

rultor · 2018-05-06T13:32:18Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2018-05-06T13:37:45Z

@rultor merge

@Vatavuk @llorllale Oops, I failed. You can see the full log here (spent 5min)


Failed tests: 
  AndInThreadsTest.worksWithProc:154 
Expected: <2>
     but: was <1>

Tests run: 992, Failures: 1, Errors: 0, Skipped: 2

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:53 min
[INFO] Finished at: 2018-05-06T13:36:33+00:00
[INFO] Final Memory: 31M/459M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project cactoos: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/r/repo/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project cactoos: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
	at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
	at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
	at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: There are test failures.

Please refer to /home/r/repo/target/surefire-reports for the individual test results.
	at org.apache.maven.plugin.surefire.SurefireHelper.reportExecution(SurefireHelper.java:91)
	at org.apache.maven.plugin.surefire.SurefirePlugin.handleSummary(SurefirePlugin.java:320)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:892)
	at org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:755)
	at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
	at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
	... 20 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
container 5417b123f3e532820f46991478543dd5a4130a2e1aebc8877401418bdd4ed729 is dead
Sun May  6 15:37:38 CEST 2018

Vatavuk · 2018-05-06T20:32:07Z

@llorllale Can you please merge again, it seems that we have also a problem with stability of AndInThreadsTest . These tests are failing randomly on my local machine also.

llorllale · 2018-05-07T14:00:51Z

@Vatavuk you're right. Please open a bug

llorllale · 2018-05-07T14:01:16Z

@rultor merge

rultor · 2018-05-07T14:02:05Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2018-05-07T14:18:13Z

@rultor merge

@llorllale Done! FYI, the full log is here (took me 16min)

0crat · 2018-05-07T14:31:50Z

@elenavolokhova /z please review this job completed by @krzyk /z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

0crat · 2018-05-07T14:32:34Z

The job #817 is now out of scope

0crat · 2018-05-07T14:32:38Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale /z

elenavolokhova · 2018-05-07T17:59:57Z

@0crat quality good

0crat · 2018-05-07T18:04:35Z

Order was finished, quality is "good": +20 point(s) just awarded to @krzyk /z

0crat · 2018-05-07T18:04:38Z

Quality review completed: +8 point(s) just awarded to @elenavolokhova /z

yegor256#692 And/Or javadoc

254b342

0crat added the scope label May 4, 2018

krzyk suggested changes May 4, 2018

View reviewed changes

yegor256#692 review comments

abf8ec8

krzyk suggested changes May 4, 2018

View reviewed changes

yegor256#692 review comments

ee45ae1

krzyk approved these changes May 4, 2018

View reviewed changes

yegor256#692 dummy commit

be66083

Vatavuk mentioned this pull request May 6, 2018

improve reliability of LoggingInputTest #776

Closed

llorllale reviewed May 6, 2018

View reviewed changes

692 expanded description

f774130

rultor merged commit f774130 into yegor256:master May 7, 2018

Vatavuk mentioned this pull request May 7, 2018

JavaDoc for the AndInThreads needs to be expanded #692

Closed

0crat removed the scope label May 7, 2018

Vatavuk mentioned this pull request May 7, 2018

Tests for AndInThreads are not stable #829

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#692 And/Or javadoc #817

#692 And/Or javadoc #817

Vatavuk commented May 4, 2018 •

edited

Loading

0crat commented May 4, 2018

0crat commented May 4, 2018

codecov-io commented May 4, 2018 •

edited

Loading

krzyk left a comment

krzyk May 4, 2018

Vatavuk commented May 4, 2018

krzyk left a comment

krzyk May 4, 2018

krzyk May 4, 2018

Vatavuk commented May 4, 2018

krzyk left a comment

krzyk commented May 4, 2018

Vatavuk commented May 6, 2018

llorllale May 6, 2018

llorllale May 6, 2018

llorllale commented May 6, 2018

Vatavuk commented May 6, 2018

llorllale commented May 6, 2018

rultor commented May 6, 2018

rultor commented May 6, 2018

Vatavuk commented May 6, 2018

llorllale commented May 7, 2018

llorllale commented May 7, 2018

rultor commented May 7, 2018

rultor commented May 7, 2018

0crat commented May 7, 2018

0crat commented May 7, 2018

0crat commented May 7, 2018

elenavolokhova commented May 7, 2018

0crat commented May 7, 2018

0crat commented May 7, 2018

#692 And/Or javadoc #817

#692 And/Or javadoc #817

Conversation

Vatavuk commented May 4, 2018 • edited Loading

0crat commented May 4, 2018

0crat commented May 4, 2018

codecov-io commented May 4, 2018 • edited Loading

Codecov Report

krzyk left a comment

Choose a reason for hiding this comment

krzyk May 4, 2018

Choose a reason for hiding this comment

Vatavuk commented May 4, 2018

krzyk left a comment

Choose a reason for hiding this comment

krzyk May 4, 2018

Choose a reason for hiding this comment

krzyk May 4, 2018

Choose a reason for hiding this comment

Vatavuk commented May 4, 2018

krzyk left a comment

Choose a reason for hiding this comment

krzyk commented May 4, 2018

Vatavuk commented May 6, 2018

llorllale May 6, 2018

Choose a reason for hiding this comment

llorllale May 6, 2018

Choose a reason for hiding this comment

llorllale commented May 6, 2018

Vatavuk commented May 6, 2018

llorllale commented May 6, 2018

rultor commented May 6, 2018

rultor commented May 6, 2018

Vatavuk commented May 6, 2018

llorllale commented May 7, 2018

llorllale commented May 7, 2018

rultor commented May 7, 2018

rultor commented May 7, 2018

0crat commented May 7, 2018

0crat commented May 7, 2018

0crat commented May 7, 2018

elenavolokhova commented May 7, 2018

0crat commented May 7, 2018

0crat commented May 7, 2018

Vatavuk commented May 4, 2018 •

edited

Loading

codecov-io commented May 4, 2018 •

edited

Loading