-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaDoc for the AndInThreads needs to be expanded #692
Comments
@driver733 from what I've seen, cactoos tends to not be too verbose with javadocs, can you please update your requirement to state exactly what test cases should be added? |
@alex-semenyuk No test cases should be added. The javadocs for the methods must be updated and expanded to clarify the confusion that happened in the referenced comments. |
@0crat in |
@llorllale Job #692 is now in scope, role is |
Bug was reported, see §29: +15 point(s) just awarded to @driver733/z |
@driver733 Please close this issue, it was solved in #817 |
@llorllale Can you close this issue, since @driver733 is on a vacation |
@llorllale ping |
@Vatavuk I agree, @driver733 is on vacation. Thanks |
There is an unrecoverable failure on my side. Please, submit it here:
1.0-SNAPSHOT: CID: 1291738138, Type: 'Close job', Author: llorllale |
@elenavolokhova/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
The job #692 is now out of scope |
@0crat quality good |
Quality review completed: +8 point(s) just awarded to @elenavolokhova/z |
As per
#687 (comment)
#687 (comment)
#687 (comment)
#687 (comment)
I think that the java doc of the
AndInThreads
class needs to be updated to include information on how the class works with various inputs. For example, it would be better if it would have a number of examples with different inputs and showing what kind of results they produce. The java doc should outline the difference between the input of, for instance, integers and booleans and in which cases would it be useful to have such inputs.The text was updated successfully, but these errors were encountered: