Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaDoc for the AndInThreads needs to be expanded #692

Closed
driver733 opened this issue Feb 20, 2018 · 17 comments
Closed

JavaDoc for the AndInThreads needs to be expanded #692

driver733 opened this issue Feb 20, 2018 · 17 comments
Labels

Comments

@driver733
Copy link
Contributor

driver733 commented Feb 20, 2018

As per
#687 (comment)
#687 (comment)
#687 (comment)
#687 (comment)

I think that the java doc of the AndInThreads class needs to be updated to include information on how the class works with various inputs. For example, it would be better if it would have a number of examples with different inputs and showing what kind of results they produce. The java doc should outline the difference between the input of, for instance, integers and booleans and in which cases would it be useful to have such inputs.

@ghost
Copy link

ghost commented Apr 17, 2018

@driver733 from what I've seen, cactoos tends to not be too verbose with javadocs, can you please update your requirement to state exactly what test cases should be added?

@driver733
Copy link
Contributor Author

@alex-semenyuk No test cases should be added. The javadocs for the methods must be updated and expanded to clarify the confusion that happened in the referenced comments.

@llorllale
Copy link
Contributor

@0crat in

@0crat 0crat added the scope label Apr 18, 2018
@0crat
Copy link
Collaborator

0crat commented Apr 18, 2018

@0crat in (here)

@llorllale Job #692 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Apr 18, 2018

Bug was reported, see §29: +15 point(s) just awarded to @driver733/z

@llorllale llorllale added the bug label Apr 20, 2018
@0crat
Copy link
Collaborator

0crat commented May 4, 2018

The job #692 assigned to @Vatavuk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

Vatavuk pushed a commit to Vatavuk/cactoos that referenced this issue May 4, 2018
Vatavuk pushed a commit to Vatavuk/cactoos that referenced this issue May 4, 2018
Vatavuk pushed a commit to Vatavuk/cactoos that referenced this issue May 4, 2018
Vatavuk pushed a commit to Vatavuk/cactoos that referenced this issue May 6, 2018
@Vatavuk
Copy link
Contributor

Vatavuk commented May 7, 2018

@driver733 Please close this issue, it was solved in #817

@Vatavuk
Copy link
Contributor

Vatavuk commented May 7, 2018

@llorllale Can you close this issue, since @driver733 is on a vacation

@Vatavuk
Copy link
Contributor

Vatavuk commented May 8, 2018

@llorllale ping

@0crat
Copy link
Collaborator

0crat commented May 9, 2018

@Vatavuk/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@llorllale
Copy link
Contributor

@Vatavuk I agree, @driver733 is on vacation. Thanks

@0crat
Copy link
Collaborator

0crat commented May 9, 2018

There is an unrecoverable failure on my side. Please, submit it here:

PID: 4@96383270-894f-4caa-b159-8adc6321d5ef, thread: AsyncFlush-6
com.zerocracy.farm.reactive.StkGroovy[125] java.lang.IllegalStateException: java.lang.reflect.InvocationTargetException in com/zerocracy/stk/pm/in/orders/close_job.groovy
sun.reflect.NativeMethodAccessorImpl[-2] java.lang.reflect.InvocationTargetException: null
com.amazonaws.http.AmazonHttpClient$RequestExecutor[1113] com.amazonaws.SdkClientException: Unable to execute HTTP request: null
sun.nio.ch.FileChannelImpl[110] java.nio.channels.ClosedChannelException: null

1.0-SNAPSHOT: CID: 1291738138, Type: 'Close job', Author: llorllale

@0crat
Copy link
Collaborator

0crat commented May 9, 2018

@elenavolokhova/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label May 9, 2018
@0crat
Copy link
Collaborator

0crat commented May 9, 2018

The job #692 is now out of scope

@elenavolokhova
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented May 10, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @Vatavuk/z

@0crat
Copy link
Collaborator

0crat commented May 10, 2018

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants