(#895, #1170) Refactor FallbackFrom and ScalarWithFallback

[baudoliver7]

#895, #1170

• Define a new interface called Fallback;
• Refactor FallbackFrom and ScalarWithFallback.

[codecov-io]

Codecov Report

Merging #1525 (1a5d730) into master (eb202e1) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1525      +/-   ##
============================================
- Coverage     90.92%   90.89%   -0.03%     
- Complexity     1550     1553       +3     
============================================
  Files           281      281              
  Lines          3680     3680              
  Branches        127      127              
============================================
- Hits           3346     3345       -1     
  Misses          304      304              
- Partials         30       31       +1     

Impacted Files	Coverage Δ	Complexity Δ
...c/main/java/org/cactoos/func/FuncWithFallback.java	100.00% <ø> (ø)	4.00 <0.00> (ø)
src/main/java/org/cactoos/func/FallbackFrom.java	100.00% <100.00%> (ø)	5.00 <1.00> (ø)
...in/java/org/cactoos/scalar/ScalarWithFallback.java	100.00% <100.00%> (ø)	10.00 <4.00> (ø)
src/main/java/org/cactoos/scalar/Solid.java	90.00% <0.00%> (-10.00%)	3.00% <0.00%> (-1.00%)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb202e1...1a5d730. Read the comment docs.

[baudoliver7]

@victornoel, look at this please. I haven't touched file src/main/java/org/cactoos/scalar/Solid.java. But Codecov/project said me there is a need to cover line 68 of Solid.java. WDYT ?

[baudoliver7]

I took the latest version of master before sending PR.

[0crat]

Job #1525 is already in scope

[baudoliver7]

It seems to be OK now.

[0crat]

Job gh:yegor256/cactoos#1525 is not assigned, can't get performer

[0crat]

Pull request #1525 was not merged, no payment for ARC, see §28

[victornoel]

@0crat status

[0crat]

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

• The job #1525 is not in scope
• Job footprint (restricted area)

[baudoliver7]

@victornoel, PR is still not in scope. Why ?

[victornoel]

@baudoliver7 because you closed it once

[victornoel]

@0crat in

[baudoliver7]

Ah, I see now.

[victornoel]

@0crat status

[0crat]

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

• The job #1525 is in scope for 3hr
• The role is REV
• The job is assigned to @fabriciofx/z for 2hr
• There is no monetary reward attached, it's a free job
• The job doesn't have any impediments
• The budget is 15 minutes/points
• These users are banned and won't be assigned:
  • @baudoliver7/z: This user reported the ticket
• Job footprint (restricted area)

[victornoel]

@baudoliver7 are a few comments

[baudoliver7]

@victornoel, I think that codecov/project checks give random results. I didn't add a new class or method but it said me code coverage level decreased.

[baudoliver7]

Please look at my last commits to get the point.

[victornoel]

@baudoliver7 yes, don't worry too much about codecov, if it's "almost" the target we will still merge it

[victornoel]

@rultor merge

[victornoel]

@baudoliver7 looks good, thx :)

[rultor]

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

[rultor]

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

[0crat]

@sereshqua/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

Job was finished in 45 hours, bonus for fast delivery is possible (see §36)

[sereshqua]

@0crat quality bad

[baudoliver7]

@sereshqua Why quality is bad ?

[sereshqua]

@baudoliver7 the reviewer -> @fabriciofx, he has not found ANY issues during code review

this PR is not anyhow related to you :)

[baudoliver7]

@sereshqua, I understand now.

[0crat]

Quality is low, no payment, see §31