-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FallbackFrom should be an interface #1170
Comments
@llorllale/z please, pay attention to this issue |
@0crat in |
@0crat in |
@0crat status |
@victornoel This is what I know about this job in C63314D6Z, as in §32:
|
@0crat status |
@fabriciofx This is what I know about this job in C63314D6Z, as in §32:
|
@fabriciofx are you going to solve this ticket? |
@victornoel yeah. I should have something done tomorrow. Sorry for late. |
@0crat refuse |
@victornoel The user @fabriciofx/z resigned from #1170, please stop working. Reason for job resignation: Order was cancelled |
@victornoel, resolving this issue will resolve also #895. Can I submit only one PR for both issues ? |
@baudoliver7 yes of course, great idea :) |
Thanks! |
@victornoel, I want to remove this PR and resend it again. |
@baudoliver7 just close it and create a new one, or force push on your branch if you want |
Ok |
@baudoliver7 thx |
@victornoel Happy to contribute ! |
@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
@baudoliver7 please make sure you start all your comments with the name of the user they are referred to, see |
@sereshqua, I get it. |
@0crat quality acceptable |
It is not possible to implement my own
FallbackFrom
.For example I would like to define an implementation of
FallbackFrom
that wraps anException
and and callsaddSupressed
on it every time it is called.For now the only solution is to do this in my own implementation of
Func
and to compose it withFallbackFrom
but I don't see why I have to bother with this extra layer of objects.The interface should be declared in
ScalarWithFallback
and a new name should be proposed for either the interface or the default implementation.See also #895
The text was updated successfully, but these errors were encountered: