Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FallbackFrom should be an interface #1170

Closed
victornoel opened this issue Jul 27, 2019 · 24 comments
Closed

FallbackFrom should be an interface #1170

victornoel opened this issue Jul 27, 2019 · 24 comments

Comments

@victornoel
Copy link
Collaborator

victornoel commented Jul 27, 2019

It is not possible to implement my own FallbackFrom.

For example I would like to define an implementation of FallbackFrom that wraps an Exception and and calls addSupressed on it every time it is called.

For now the only solution is to do this in my own implementation of Func and to compose it with FallbackFrom but I don't see why I have to bother with this extra layer of objects.

The interface should be declared in ScalarWithFallback and a new name should be proposed for either the interface or the default implementation.

See also #895

@0crat
Copy link
Collaborator

0crat commented Jul 27, 2019

@llorllale/z please, pay attention to this issue

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat status

@0crat
Copy link
Collaborator

0crat commented Sep 27, 2020

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@fabriciofx
Copy link
Contributor

@0crat status

@0crat
Copy link
Collaborator

0crat commented Oct 1, 2020

@0crat status (here)

@fabriciofx This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator Author

@fabriciofx are you going to solve this ticket?

@fabriciofx
Copy link
Contributor

fabriciofx commented Nov 1, 2020

@victornoel yeah. I should have something done tomorrow. Sorry for late.

@victornoel
Copy link
Collaborator Author

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2020

@0crat refuse (here)

@victornoel The user @fabriciofx/z resigned from #1170, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Jan 6, 2021

The job #1170 assigned to @baudoliver7/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@baudoliver7
Copy link
Contributor

@victornoel, resolving this issue will resolve also #895. Can I submit only one PR for both issues ?

@victornoel
Copy link
Collaborator Author

@baudoliver7 yes of course, great idea :)

@baudoliver7
Copy link
Contributor

Thanks!

@baudoliver7
Copy link
Contributor

@victornoel, I want to remove this PR and resend it again.

@victornoel
Copy link
Collaborator Author

@baudoliver7 just close it and create a new one, or force push on your branch if you want

@baudoliver7
Copy link
Contributor

Ok

@victornoel
Copy link
Collaborator Author

@baudoliver7 thx

@baudoliver7
Copy link
Contributor

@victornoel Happy to contribute !

@0crat 0crat added qa and removed 0crat/scope labels Jan 11, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 11, 2021

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@sereshqua
Copy link

@baudoliver7 please make sure you start all your comments with the name of the user they are referred to, see

@baudoliver7
Copy link
Contributor

@sereshqua, I get it.

@sereshqua
Copy link

@0crat quality acceptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants