Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1170, #895) Refactor FallbackFrom and simplify ScalarWithFallback #1524

Conversation

baudoliver7
Copy link
Contributor

#1170, #895

  • Refactor FallbackFrom by introducing a new interface
  • Declare Fallback interface in ScalarWithFallback

@codecov-io
Copy link

codecov-io commented Jan 8, 2021

Codecov Report

Merging #1524 (b449a35) into master (019f965) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1524      +/-   ##
============================================
+ Coverage     90.88%   90.92%   +0.03%     
- Complexity     1553     1554       +1     
============================================
  Files           281      281              
  Lines          3687     3680       -7     
  Branches        127      127              
============================================
- Hits           3351     3346       -5     
+ Misses          306      304       -2     
  Partials         30       30              
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/cactoos/func/FuncWithFallback.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
src/main/java/org/cactoos/text/Rotated.java 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/main/java/org/cactoos/func/FallbackFrom.java 100.00% <100.00%> (ø) 5.00 <1.00> (ø)
src/main/java/org/cactoos/iterable/Repeated.java 100.00% <100.00%> (ø) 3.00 <1.00> (-1.00)
src/main/java/org/cactoos/iterator/Repeated.java 84.61% <100.00%> (ø) 6.00 <1.00> (ø)
src/main/java/org/cactoos/scalar/AvgOf.java 100.00% <100.00%> (ø) 17.00 <5.00> (+1.00)
...in/java/org/cactoos/scalar/ScalarWithFallback.java 100.00% <100.00%> (ø) 10.00 <4.00> (ø)
src/main/java/org/cactoos/text/FormattedText.java 100.00% <100.00%> (ø) 9.00 <1.00> (ø)
src/main/java/org/cactoos/text/Split.java 100.00% <100.00%> (+9.52%) 9.00 <7.00> (ø)
src/main/java/org/cactoos/iterator/Joined.java 100.00% <0.00%> (ø) 8.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019f965...b449a35. Read the comment docs.

@baudoliver7 baudoliver7 closed this Jan 8, 2021
@baudoliver7 baudoliver7 deleted the 1170_895_FallbackFrom_should_be_an_interface branch January 8, 2021 09:53
@0crat 0crat added the qa label Jan 8, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 8, 2021

Job was finished in 0 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Jan 8, 2021

@sereshqua/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the 0crat/scope label Jan 8, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 8, 2021

Pull request #1524 was not merged, no payment for ARC, see §28

@sereshqua
Copy link

@0crat quality bad

@0crat 0crat added quality/bad and removed qa labels Jan 8, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 8, 2021

Quality is low, no payment, see §31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants