fix: Internal Server Error when invalid vaults #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
karelianpie
commented
May 23, 2023
Majorfi
requested changes
May 23, 2023
Majorfi
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Googlebot, or a user goes to an invalid
/vaultsroute -- be it an invalid chainID or an invalid vault address the app crashes with a 500 Internal Server Error, i.e. https://yearn.finance/vaults/invest/0xA74d4B67b3368E83797a35382AFB776bAAE4F5C8The way to solve this is to validate both dynamic routes,
chainIDandaddressand only allow through the valid routes. The ones that do not have a validchainIDnoraddressshould return 404 so that Google's crawler stops crawling them.Related Issue
Fix #194
Motivation and Context
Prevent 500 Internal Server Error and gracefully return 404 for invalid routes
How Has This Been Tested?
Ran locally, went to invalid routes and observed 404 and valid routes working as expected
Screenshots (if appropriate):