fix: Invalid json response body when address is null #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Majorfi
reviewed
May 23, 2023
karelianpie
force-pushed
the
fix/invalid-json-response-body
branch
from
163d524
to
efb904f
Compare
karelianpie
force-pushed
the
fix/invalid-json-response-body
branch
from
efb904f
to
a72ef10
Compare
Majorfi
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
addresscan benullwhich makes the request fail, i.e. http://yearn.finance/vaults/250/nullRelated Issue
Fix https://xopowo-team.sentry.io/issues/4188080554/events/137bc2594c664531a5f7437c32bba774/
Motivation and Context
Avoid unnecessary fetches when the endpoint is not valid
How Has This Been Tested?
Checked http://localhost:3000/vaults/1/null
Screenshots (if appropriate):
Not a great empty screen for a vault, but we can implement an empty view in another PR