Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comments in Vault.vy #314

Merged
merged 2 commits into from
May 11, 2021
Merged

fix: comments in Vault.vy #314

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
234afd9
docs: typo of default symbol
antoncoding May 4, 2021
527bc65
docs: corrected saved gas post berlin
antoncoding May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/Vault.vy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def initialize(
If `nameOverride` is not specified, the name will be 'yearn'
combined with the name of `token`.

If `symbolOverride` is not specified, the symbol will be 'y'
If `symbolOverride` is not specified, the symbol will be 'yv'
combined with the symbol of `token`.
@param token The token that may be deposited into this Vault.
@param governance The address authorized for governance interactions.
Expand Down Expand Up @@ -797,7 +797,7 @@ def _issueSharesForAmount(to: address, amount: uint256) -> uint256:
# calculation will be wrong. This means that only *trusted* tokens
# (with no capability for exploitative behavior) can be used.
shares: uint256 = 0
# HACK: Saves 2 SLOADs (~4000 gas)
# HACK: Saves 2 SLOADs (~200 gas, post-Berlin)
totalSupply: uint256 = self.totalSupply
if totalSupply > 0:
# Mint amount of shares based on what the Vault is managing overall
Expand Down