Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comments in Vault.vy #314

Merged
merged 2 commits into from
May 11, 2021
Merged

fix: comments in Vault.vy #314

merged 2 commits into from
May 11, 2021

Conversation

antoncoding
Copy link
Contributor

Fix comments in Vault.vy

  1. The default symbol starts with yv instead of y
  2. Gas of 2 SLOADs drops from 4000 to 200.

@antoncoding antoncoding changed the title Fix comments in Vault.vy fix: comments in Vault.vy May 4, 2021
@ghost
Copy link

ghost commented May 4, 2021

Make sure your commit history contains messages that comply with https://github.com/conventional-changelog/commitlint/#what-is-commitlint

@fubuloubu fubuloubu merged commit 98e2bf7 into yearn:master May 11, 2021
@antoncoding antoncoding deleted the fix/vaults-comment branch May 11, 2021 17:02
orbxball pushed a commit to orbxball/yearn-vaults that referenced this pull request Aug 8, 2021
* docs: typo of default symbol

* docs: corrected saved gas post berlin
sambacha pushed a commit to sambacha/yearn-vaults that referenced this pull request Sep 7, 2021
* docs: typo of default symbol

* docs: corrected saved gas post berlin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants