Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add script ‘lintfix’ #212

Merged
merged 1 commit into from
May 31, 2023
Merged

chore: Add script ‘lintfix’ #212

merged 1 commit into from
May 31, 2023

Conversation

Itzabelli
Copy link
Collaborator

Description

The lintfix script was added to facilitate the automatically fixes the trivial warnings identified after lint script run. These fixes are made directly in the code according to the rules set at the web-lib/.eslintrc.cjs file.

Motivation and Context

I thought it would be important to suggest this change with the motivation of standardizing the package.json file with that of the yPartners repo and make easily accessible the --fix method of the lint dependency

@Itzabelli Itzabelli requested a review from 0xMirim May 30, 2023 10:01
@vercel
Copy link

vercel bot commented May 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ape-tax ✅ Ready (Inspect) Visit Preview May 30, 2023 10:01am

@Majorfi Majorfi merged commit 1321ccc into typescript May 31, 2023
@Majorfi Majorfi deleted the add-script-lintfix branch May 31, 2023 12:09
Copy link
Contributor

@0xMirim 0xMirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

0xMirim added a commit that referenced this pull request Jun 1, 2023
* feat: migrate to typescript

* fix: merge

* fix: remove exta file

* fix: some issues

* fix: matic

* fix: ts issues

* fix: bump node on vercel

* fix: bump node on vercel

* fix: color

* fix: copy change

* refactor: Adjust styles to improve readability and Plausible setup (#198)

* feat: setup plausible

* style: Adjust text color property

* style: Adjust text color

* style: Attempt to standardize colors for titles, text, and borders

* chore: add Issue / PR Templates

---------

Co-authored-by: Itzabelli <104786213+Itzabelli@users.noreply.github.com>

* chore: Correct name of templates folder (#199)

Folder was accidently named "github" instead of ".github" meaning it wasn't usable in the way we originally intended

* style: adjust text styles to improve readability (#200)

Minor adjustments to more clearly show difference between labels and dyanamic values

* fix: Resolve console error by avoiding nested <a> tags (#202)

Error present because vault items contain links but tags (within these items) also link to other sites

* refactor: Change CG Symbol to always be lowercase (#204)

in vaults.json this attribute was sometimes upperase sometimes lowercase causing confusion when adding new entries

* chore: Improve responsiveness of header (#208)

Adjust media query of the title

* refactor: Update react imports (#209)

Adjust and remove unnecessary imports

* fix: Resolve infinite load on vault apr (#210)

The suspense condition was causing loading to go on forever, slight adjustment corrected this

* chore: Add script ‘lintfix’ (#212)

* chore: Improve responsiveness of deploy vault button (#213)

---------

Co-authored-by: 0xMirim <95051992+0xMirim@users.noreply.github.com>
Co-authored-by: Itzabelli <104786213+Itzabelli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants