fix: resolve nested links console error #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error present because vault items contain links but tags (within these items) also link to other sites
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xMirim
changed the title
Majorfi
approved these changes
May 26, 2023
0xMirim
added a commit
that referenced
this pull request
Jun 1, 2023
* feat: migrate to typescript * fix: merge * fix: remove exta file * fix: some issues * fix: matic * fix: ts issues * fix: bump node on vercel * fix: bump node on vercel * fix: color * fix: copy change * refactor: Adjust styles to improve readability and Plausible setup (#198) * feat: setup plausible * style: Adjust text color property * style: Adjust text color * style: Attempt to standardize colors for titles, text, and borders * chore: add Issue / PR Templates --------- Co-authored-by: Itzabelli <104786213+Itzabelli@users.noreply.github.com> * chore: Correct name of templates folder (#199) Folder was accidently named "github" instead of ".github" meaning it wasn't usable in the way we originally intended * style: adjust text styles to improve readability (#200) Minor adjustments to more clearly show difference between labels and dyanamic values * fix: Resolve console error by avoiding nested <a> tags (#202) Error present because vault items contain links but tags (within these items) also link to other sites * refactor: Change CG Symbol to always be lowercase (#204) in vaults.json this attribute was sometimes upperase sometimes lowercase causing confusion when adding new entries * chore: Improve responsiveness of header (#208) Adjust media query of the title * refactor: Update react imports (#209) Adjust and remove unnecessary imports * fix: Resolve infinite load on vault apr (#210) The suspense condition was causing loading to go on forever, slight adjustment corrected this * chore: Add script ‘lintfix’ (#212) * chore: Improve responsiveness of deploy vault button (#213) --------- Co-authored-by: 0xMirim <95051992+0xMirim@users.noreply.github.com> Co-authored-by: Itzabelli <104786213+Itzabelli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a distracting error we get in the console as seen below. The error has to do with
Tagcomponent inindex.tsx. TheTagcomponent by itself is ok since it's really just a wrapper for tags that to link other sites.The issues comes in when we use
Tagwithin eachLinkbecause link is also underthehood so we get this nested links error. The solution was just to examine the HTML structure and make minimal adjustments to removeTagfrom within theLinkwhile preserving the original appearance. It was a bit tricky but I think this solution is good.