Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse topic's partitioning once and more efficiently #9914

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Sep 30, 2024

Changelog entry

Parse CDC topic's partitioning once and more efficiently.

Changelog category

  • Performance improvement

Additional information

  • More efficient parsing algorithm.
  • Parse once.

@CyberROFL CyberROFL requested a review from Enjection September 30, 2024 18:02
@CyberROFL CyberROFL self-assigned this Sep 30, 2024
@CyberROFL CyberROFL marked this pull request as ready for review September 30, 2024 18:02
Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 18:02:54 UTC Pre-commit check linux-x86_64-release-asan for b91e83a has started.
2024-09-30 18:02:59 UTC Artifacts will be uploaded here
2024-09-30 18:05:57 UTC ya make is running...
🟡 2024-09-30 20:13:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11867 11663 0 44 40 120

🟢 2024-09-30 20:14:45 UTC Build successful.
🟡 2024-09-30 20:15:18 UTC ydbd size 5.7 GiB changed* by +566.3 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63af4d0 merge: b91e83a diff diff %
ydbd size 6 085 512 040 Bytes 6 086 091 952 Bytes +566.3 KiB +0.010%
ydbd stripped size 1 520 430 704 Bytes 1 520 467 440 Bytes +35.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 30, 2024

2024-09-30 18:03:43 UTC Pre-commit check linux-x86_64-relwithdebinfo for b91e83a has started.
2024-09-30 18:03:48 UTC Artifacts will be uploaded here
2024-09-30 18:06:57 UTC ya make is running...
🟡 2024-09-30 19:22:41 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41247 35683 0 1 5459 104

2024-09-30 19:26:17 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-30 19:37:35 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
98 (only retried tests) 5 0 0 0 93

🟢 2024-09-30 19:37:41 UTC Build successful.
🟡 2024-09-30 19:38:02 UTC ydbd size 2.8 GiB changed* by +301.1 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 63af4d0 merge: b91e83a diff diff %
ydbd size 3 001 595 304 Bytes 3 001 903 616 Bytes +301.1 KiB +0.010%
ydbd stripped size 477 347 400 Bytes 477 360 904 Bytes +13.2 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL enabled auto-merge (squash) September 30, 2024 18:24
@CyberROFL CyberROFL requested a review from snaury October 1, 2024 10:18
@CyberROFL CyberROFL requested a review from snaury October 1, 2024 10:28
Copy link

github-actions bot commented Oct 1, 2024

2024-10-01 10:31:07 UTC Pre-commit check linux-x86_64-release-asan for f877a3e has started.
2024-10-01 10:31:17 UTC Artifacts will be uploaded here
2024-10-01 10:34:18 UTC ya make is running...
🟡 2024-10-01 12:25:04 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11861 11663 0 36 40 122

🟢 2024-10-01 12:26:05 UTC Build successful.
🟡 2024-10-01 12:26:41 UTC ydbd size 5.7 GiB changed* by +558.8 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 051c6cb merge: f877a3e diff diff %
ydbd size 6 085 521 088 Bytes 6 086 093 336 Bytes +558.8 KiB +0.009%
ydbd stripped size 1 520 431 728 Bytes 1 520 466 864 Bytes +34.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 1, 2024

2024-10-01 10:31:51 UTC Pre-commit check linux-x86_64-relwithdebinfo for f877a3e has started.
2024-10-01 10:32:02 UTC Artifacts will be uploaded here
2024-10-01 10:35:02 UTC ya make is running...
🟡 2024-10-01 11:33:13 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
41248 35680 0 3 5458 107

2024-10-01 11:36:40 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-01 11:47:55 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
101 (only retried tests) 9 0 0 0 92

🟢 2024-10-01 11:48:02 UTC Build successful.
🟡 2024-10-01 11:48:33 UTC ydbd size 2.8 GiB changed* by +297.4 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 051c6cb merge: f877a3e diff diff %
ydbd size 3 001 600 736 Bytes 3 001 905 280 Bytes +297.4 KiB +0.010%
ydbd stripped size 477 348 040 Bytes 477 361 096 Bytes +12.8 KiB +0.003%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@CyberROFL CyberROFL merged commit 4d8f724 into ydb-platform:main Oct 1, 2024
10 checks passed
@CyberROFL CyberROFL deleted the optimize-parsing branch October 1, 2024 12:28
CyberROFL added a commit to CyberROFL/ydb that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants