Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

24-3: parse topic's partitioning once and more efficiently, better handling of connection loss #10028

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

CyberROFL
Copy link
Member

@CyberROFL CyberROFL commented Oct 3, 2024

Changelog entry

  • Parse CDC topic's partitioning once and more efficiently.
  • Improved connection loss handling in CDC.

Changelog category

  • Performance improvement

Additional information

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 09:15:11 UTC Pre-commit check for 9bea290 has started.
2024-10-03 09:18:00 UTC Build linux-x86_64-release-asan is running...
🔴 2024-10-03 09:21:12 UTC Build failed. see the build logs.
🔴 2024-10-03 09:21:14 UTC Tests run skipped.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 09:15:38 UTC Pre-commit check for 9bea290 has started.
2024-10-03 09:18:23 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-10-03 09:21:37 UTC Build failed. see the build logs.
🔴 2024-10-03 09:21:39 UTC Tests run skipped.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 09:16:21 UTC Pre-commit check for 9bea290 has started.
2024-10-03 09:19:08 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-10-03 09:27:13 UTC Build failed. see the build logs.

@CyberROFL CyberROFL self-assigned this Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 09:31:45 UTC Pre-commit check for da13271 has started.
2024-10-03 09:34:29 UTC Build linux-x86_64-relwithdebinfo is running...
🔴 2024-10-03 09:39:01 UTC Build failed. see the build logs.
🔴 2024-10-03 09:39:03 UTC Tests run skipped.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 09:32:41 UTC Pre-commit check for da13271 has started.
2024-10-03 09:35:24 UTC Build linux-x86_64-release-clang14 is running...
🔴 2024-10-03 09:39:42 UTC Build failed. see the build logs.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 09:33:10 UTC Pre-commit check for da13271 has started.
2024-10-03 09:35:54 UTC Build linux-x86_64-release-asan is running...
🔴 2024-10-03 09:40:12 UTC Build failed. see the build logs.
🔴 2024-10-03 09:40:14 UTC Tests run skipped.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 10:14:20 UTC Pre-commit check for bf1ae83 has started.
2024-10-03 10:17:11 UTC Check cancelled

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 10:19:48 UTC Pre-commit check for 8918723 has started.
2024-10-03 10:23:03 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-03 11:02:00 UTC Build successful.
2024-10-03 11:02:14 UTC Tests are running...
🔴 2024-10-03 12:03:17 UTC Test run completed, no test results found for commit 88c4b6a. Please check test log.
🟡 2024-10-03 12:03:51 UTC ydbd size 5.6 GiB changed* by +532.4 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: b5dae67 merge: 8918723 diff diff %
ydbd size 5 961 263 400 Bytes 5 961 808 576 Bytes +532.4 KiB +0.009%
ydbd stripped size 1 491 909 824 Bytes 1 491 940 832 Bytes +30.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-03 12:03:53 UTC Check cancelled

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 10:23:16 UTC Pre-commit check for 8918723 has started.
2024-10-03 10:26:06 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-03 11:24:35 UTC Build successful.
2024-10-03 11:24:52 UTC Tests are running...
🔴 2024-10-03 12:03:16 UTC Test run completed, no test results found for commit 88c4b6a. Please check test log.
🔴 2024-10-03 12:04:03 UTC ydbd size 8.2 GiB changed* by +2.2 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: b5dae67 merge: 8918723 diff diff %
ydbd size 8 803 041 592 Bytes 8 805 377 008 Bytes +2.2 MiB +0.027%
ydbd stripped size 480 052 584 Bytes 480 058 024 Bytes +5.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-03 12:04:05 UTC Check cancelled

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 10:25:17 UTC Pre-commit check for 8918723 has started.
2024-10-03 10:31:12 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-03 11:07:53 UTC Build successful.

@CyberROFL CyberROFL marked this pull request as ready for review October 3, 2024 10:51
@CyberROFL CyberROFL requested a review from a team as a code owner October 3, 2024 10:51
@CyberROFL CyberROFL enabled auto-merge (squash) October 3, 2024 11:31
Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 12:05:30 UTC Pre-commit check for 8918723 has started.
2024-10-03 12:08:21 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-03 12:31:00 UTC Build successful.
2024-10-03 12:31:13 UTC Tests are running...
🔴 2024-10-03 14:10:57 UTC Test run completed, no test results found for commit 88c4b6a. Please check test log.
🟡 2024-10-03 14:11:33 UTC ydbd size 5.6 GiB changed* by +532.4 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: b5dae67 merge: 8918723 diff diff %
ydbd size 5 961 263 400 Bytes 5 961 808 576 Bytes +532.4 KiB +0.009%
ydbd stripped size 1 491 909 824 Bytes 1 491 940 832 Bytes +30.3 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-03 14:11:35 UTC Check cancelled

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 12:06:07 UTC Pre-commit check for 8918723 has started.
2024-10-03 12:09:29 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-03 12:14:28 UTC Build successful.

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 12:06:20 UTC Pre-commit check for 8918723 has started.
2024-10-03 12:09:11 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-03 12:48:06 UTC Build successful.
2024-10-03 12:48:22 UTC Tests are running...
🔴 2024-10-03 14:10:57 UTC Test run completed, no test results found for commit 88c4b6a. Please check test log.
🔴 2024-10-03 14:11:45 UTC ydbd size 8.2 GiB changed* by +2.2 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: b5dae67 merge: 8918723 diff diff %
ydbd size 8 803 041 592 Bytes 8 805 377 008 Bytes +2.2 MiB +0.027%
ydbd stripped size 480 052 584 Bytes 480 058 024 Bytes +5.3 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
2024-10-03 14:11:47 UTC Check cancelled

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 14:13:57 UTC Pre-commit check for fa8b876 has started.
2024-10-03 14:16:45 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-10-03 15:12:40 UTC Build successful.
2024-10-03 15:12:55 UTC Tests are running...
🔴 2024-10-03 16:58:33 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39904 34642 0 7 5213 42

🔴 2024-10-03 16:59:15 UTC ydbd size 8.2 GiB changed* by +2.2 MiB, which is >= 2.0 MiB vs stable-24-3: Alert

ydbd size dash stable-24-3: 66970a9 merge: fa8b876 diff diff %
ydbd size 8 803 214 320 Bytes 8 805 544 328 Bytes +2.2 MiB +0.026%
ydbd stripped size 480 064 488 Bytes 480 069 480 Bytes +4.9 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 14:14:10 UTC Pre-commit check for fa8b876 has started.
2024-10-03 14:16:59 UTC Build linux-x86_64-release-asan is running...
🟢 2024-10-03 14:54:27 UTC Build successful.
2024-10-03 14:54:42 UTC Tests are running...
🔴 2024-10-03 16:50:44 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11368 11278 0 15 27 48

🟡 2024-10-03 16:51:21 UTC ydbd size 5.6 GiB changed* by +527.6 KiB, which is >= 100.0 KiB vs stable-24-3: Warning

ydbd size dash stable-24-3: 66970a9 merge: fa8b876 diff diff %
ydbd size 5 961 535 736 Bytes 5 962 075 968 Bytes +527.6 KiB +0.009%
ydbd stripped size 1 491 956 256 Bytes 1 491 985 920 Bytes +29.0 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Oct 3, 2024

2024-10-03 14:14:25 UTC Pre-commit check for fa8b876 has started.
2024-10-03 14:17:13 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-10-03 14:49:33 UTC Build successful.

@CyberROFL CyberROFL merged commit 6e988c4 into ydb-platform:stable-24-3 Oct 3, 2024
8 of 12 checks passed
@CyberROFL CyberROFL deleted the optimizations-24-3 branch October 7, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants