Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy IC setting leading to performance degradation (merge from main #9707) #9721

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 24, 2024

Changelog entry

Fix buggy IC setting leading to performance degradation

Changelog category

  • Performance improvement

Additional information

Default setting of 512k send buffer size leads to performance degradation on modern networks, making IC unable to reach its top performance. Default setting has been removed.

@alexvru alexvru requested a review from a team as a code owner September 24, 2024 15:26
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 15:27:26 UTC Pre-commit check for a7ed062 has started.
2024-09-24 15:30:16 UTC Build linux-x86_64-release-asan is running...
🟢 2024-09-24 16:11:13 UTC Build successful.
2024-09-24 16:11:27 UTC Tests are running...
🔴 2024-09-24 18:07:48 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
11766 11686 0 9 35 36

🟢 2024-09-24 18:08:27 UTC ydbd size 5.5 GiB changed* by -336 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 97ff008 merge: a7ed062 diff diff %
ydbd size 5 935 805 688 Bytes 5 935 805 352 Bytes -336 Bytes -0.000%
ydbd stripped size 1 488 067 808 Bytes 1 488 067 744 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 15:28:32 UTC Pre-commit check for a7ed062 has started.
2024-09-24 15:32:02 UTC Build linux-x86_64-relwithdebinfo is running...
🟢 2024-09-24 16:36:16 UTC Build successful.
2024-09-24 16:36:31 UTC Tests are running...
🔴 2024-09-24 18:57:49 UTC Some tests failed, follow the links below.

Test history | Test log

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
72897 59432 0 6 13424 35

🟢 2024-09-24 18:58:34 UTC ydbd size 8.2 GiB changed* by -608 Bytes, which is <= 0 Bytes vs stable-24-3: OK

ydbd size dash stable-24-3: 97ff008 merge: a7ed062 diff diff %
ydbd size 8 764 165 448 Bytes 8 764 164 840 Bytes -608 Bytes -0.000%
ydbd stripped size 479 110 088 Bytes 479 110 088 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 15:32:03 UTC Pre-commit check for a7ed062 has started.
2024-09-24 15:34:55 UTC Build linux-x86_64-release-clang14 is running...
🟢 2024-09-24 16:11:50 UTC Build successful.

@alexvru alexvru merged commit 6950c41 into ydb-platform:stable-24-3 Sep 26, 2024
8 of 12 checks passed
@alexvru alexvru deleted the merge/24-3/9707 branch September 26, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants