Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy IC setting leading to performance degradation #9707

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Sep 24, 2024

Changelog entry

Fix buggy IC setting leading to performance degradation

Changelog category

  • Performance improvement

Additional information

Default setting of 512k send buffer size leads to performance degradation on modern networks, making IC unable to reach its top performance. Default setting has been removed.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:35:17 UTC Pre-commit check linux-x86_64-release-clang14 for b33b062 has started.
2024-09-24 12:35:26 UTC Artifacts will be uploaded here
2024-09-24 12:38:36 UTC ya make is running...
2024-09-24 12:58:35 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:35:33 UTC Pre-commit check linux-x86_64-release-asan for b33b062 has started.
2024-09-24 12:35:43 UTC Artifacts will be uploaded here
2024-09-24 12:38:56 UTC ya make is running...
2024-09-24 12:58:36 UTC Check cancelled

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 12:35:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for b33b062 has started.
2024-09-24 12:35:45 UTC Artifacts will be uploaded here
2024-09-24 12:39:01 UTC ya make is running...
2024-09-24 12:58:35 UTC Check cancelled

va-kuznecov
va-kuznecov previously approved these changes Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 13:04:12 UTC Pre-commit check linux-x86_64-release-asan for 5d1473c has started.
2024-09-24 13:04:22 UTC Artifacts will be uploaded here
2024-09-24 13:07:32 UTC ya make is running...
🔴 2024-09-24 15:05:29 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12354 12142 0 38 50 124

🟢 2024-09-24 15:06:33 UTC Build successful.
🟢 2024-09-24 15:07:06 UTC ydbd size 5.7 GiB changed* by -336 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 63a6a81 merge: 5d1473c diff diff %
ydbd size 6 080 250 272 Bytes 6 080 249 936 Bytes -336 Bytes -0.000%
ydbd stripped size 1 520 057 904 Bytes 1 520 057 840 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 13:09:22 UTC Pre-commit check linux-x86_64-release-clang14 for 5d1473c has started.
2024-09-24 13:09:31 UTC Artifacts will be uploaded here
2024-09-24 13:12:41 UTC ya make is running...
🟢 2024-09-24 13:37:04 UTC Build successful.

Copy link

github-actions bot commented Sep 24, 2024

2024-09-24 13:10:58 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5d1473c has started.
2024-09-24 13:11:02 UTC Artifacts will be uploaded here
2024-09-24 13:14:10 UTC ya make is running...
🟡 2024-09-24 14:42:20 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
74885 60930 0 8 13834 113

2024-09-24 14:49:18 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-24 15:00:48 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 32 0 1 0 98

2024-09-24 15:00:57 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-24 15:22:05 UTC Tests successful.

Test history | Ya make output

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
104 (only retried tests) 7 0 0 0 97

🟢 2024-09-24 15:22:12 UTC Build successful.
🟢 2024-09-24 15:23:09 UTC ydbd size 8.5 GiB changed* by -656 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 63a6a81 merge: 5d1473c diff diff %
ydbd size 9 073 184 704 Bytes 9 073 184 048 Bytes -656 Bytes -0.000%
ydbd stripped size 490 587 400 Bytes 490 587 400 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru enabled auto-merge (squash) September 24, 2024 14:19
@alexvru alexvru merged commit 92d046c into ydb-platform:main Sep 24, 2024
10 of 12 checks passed
@alexvru alexvru deleted the interconnect/fix-buggy-setting branch September 24, 2024 15:23
@alexvru alexvru restored the interconnect/fix-buggy-setting branch September 24, 2024 15:23
@alexvru alexvru deleted the interconnect/fix-buggy-setting branch September 24, 2024 15:23
rekby pushed a commit to rekby-forks/ydb that referenced this pull request Sep 24, 2024
@alexvru alexvru self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants