generic_lookup_actor: add basic error handling #9396

yumkam · 2024-09-17T16:43:13Z

Changelog entry

...

Changelog category

Not for changelog (changelog entry is not required)

Additional information

...

github-actions · 2024-09-17T16:44:34Z

⚪ 2024-09-17 16:44:33 UTC Pre-commit check linux-x86_64-release-asan for 0089403 has started.
⚪ 2024-09-17 16:44:43 UTC Artifacts will be uploaded here
⚪ 2024-09-17 16:47:40 UTC ya make is running...
🔴 2024-09-17 18:57:06 UTC Some tests failed, follow the links below.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10429	10228	0	47	49	105

🟢 2024-09-17 18:58:03 UTC Build successful.
🟡 2024-09-17 18:58:37 UTC ydbd size 5.6 GiB changed* by +333.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `90e3198`	merge: `0089403`	diff	diff %
ydbd size	6 048 278 984 Bytes	6 048 620 496 Bytes	+333.5 KiB	+0.006%
ydbd stripped size	1 513 325 936 Bytes	1 513 405 264 Bytes	+77.5 KiB	+0.005%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-17T16:44:36Z

⚪ 2024-09-17 16:44:35 UTC Pre-commit check linux-x86_64-release-clang14 for 0089403 has started.
⚪ 2024-09-17 16:44:44 UTC Artifacts will be uploaded here
⚪ 2024-09-17 16:47:44 UTC ya make is running...
🟢 2024-09-17 17:33:57 UTC Build successful.

github-actions · 2024-09-17T16:44:40Z

⚪ 2024-09-17 16:44:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0089403 has started.
⚪ 2024-09-17 16:44:50 UTC Artifacts will be uploaded here
⚪ 2024-09-17 16:47:40 UTC ya make is running...
🟡 2024-09-17 18:14:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39586	33879	0	5	5667	35

⚪ 2024-09-17 18:18:43 UTC ya make is running... (failed tests rerun, try 2)
🟡 2024-09-17 18:29:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
275 (only retried tests)	178	0	1	7	89

⚪ 2024-09-17 18:30:08 UTC ya make is running... (failed tests rerun, try 3)
🟢 2024-09-17 18:41:18 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
95 (only retried tests)	6	0	0	0	89

🟢 2024-09-17 18:41:25 UTC Build successful.
🟡 2024-09-17 18:42:03 UTC ydbd size 8.4 GiB changed* by +102.5 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash	main: `3a4de79`	merge: `0089403`	diff	diff %
ydbd size	9 034 329 400 Bytes	9 034 434 400 Bytes	+102.5 KiB	+0.001%
ydbd stripped size	488 824 072 Bytes	488 825 736 Bytes	+1.6 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

uzhastik · 2024-09-17T17:03:09Z

ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp

+                                  NConnector::ErrorToIssues(error),
+                                  NConnector::ErrorToDqStatus(error));
+            actorSystem->Send(new NActors::IEventHandle(ParentId, SelfId(), errEv));
+            auto guard = Guard(*Alloc);


давай эти три строчки вынесем в отдельную функцию, копипаста есть

ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp

there should be no attempt to use generic lookup upon sending a error

github-actions · 2024-09-27T14:23:57Z

⚪ 2024-09-27 14:23:56 UTC Pre-commit check linux-x86_64-release-asan for c37a2b6 has started.
⚪ 2024-09-27 14:24:06 UTC Artifacts will be uploaded here
⚪ 2024-09-27 14:27:06 UTC ya make is running...
🟡 2024-09-27 16:51:03 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10560	10324	0	61	53	122

🟢 2024-09-27 16:52:01 UTC Build successful.
🟢 2024-09-27 16:52:38 UTC ydbd size 5.7 GiB changed* by +53.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `31a439a`	merge: `c37a2b6`	diff	diff %
ydbd size	6 085 918 048 Bytes	6 085 972 392 Bytes	+53.1 KiB	+0.001%
ydbd stripped size	1 521 182 640 Bytes	1 521 186 800 Bytes	+4.1 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-09-27T14:25:45Z

⚪ 2024-09-27 14:25:44 UTC Pre-commit check linux-x86_64-relwithdebinfo for c37a2b6 has started.
⚪ 2024-09-27 14:25:48 UTC Artifacts will be uploaded here
⚪ 2024-09-27 14:28:39 UTC ya make is running...
🟡 2024-09-27 17:39:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39731	34166	0	7	5458	100

⚪ 2024-09-27 17:42:36 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-09-27 17:57:21 UTC Tests successful.

Test history | Ya make output

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
103 (only retried tests)	12	0	0	0	91

🟢 2024-09-27 17:57:27 UTC Build successful.
🟢 2024-09-27 17:57:48 UTC ydbd size 2.8 GiB changed* by +25.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `31a439a`	merge: `c37a2b6`	diff	diff %
ydbd size	2 999 709 152 Bytes	2 999 735 312 Bytes	+25.5 KiB	+0.001%
ydbd stripped size	476 857 000 Bytes	476 858 408 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp

github-actions · 2024-10-10T14:30:01Z

⚪ 2024-10-10 14:30:00 UTC Pre-commit check linux-x86_64-release-asan for dc9183c has started.
⚪ 2024-10-10 14:30:31 UTC Artifacts will be uploaded here
⚪ 2024-10-10 14:33:22 UTC ya make is running...
🟡 2024-10-10 15:54:14 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
10341	10110	0	69	53	109

🟢 2024-10-10 15:55:07 UTC Build successful.
🟢 2024-10-10 15:55:39 UTC ydbd size 5.7 GiB changed* by +63.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `89cd280`	merge: `dc9183c`	diff	diff %
ydbd size	6 103 985 064 Bytes	6 104 049 952 Bytes	+63.4 KiB	+0.001%
ydbd stripped size	1 521 011 952 Bytes	1 521 018 032 Bytes	+5.9 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

github-actions · 2024-10-10T14:31:47Z

⚪ 2024-10-10 14:31:47 UTC Pre-commit check linux-x86_64-relwithdebinfo for dc9183c has started.
⚪ 2024-10-10 14:31:57 UTC Artifacts will be uploaded here
⚪ 2024-10-10 14:34:48 UTC ya make is running...
🟡 2024-10-10 15:31:16 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
39852	34106	0	5	5697	44

⚪ 2024-10-10 15:34:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2024-10-10 15:46:10 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS	PASSED	ERRORS	FAILED	SKIPPED	MUTED^?
279 (only retried tests)	171	0	0	7	101

🟢 2024-10-10 15:46:18 UTC Build successful.
🟢 2024-10-10 15:46:39 UTC ydbd size 2.8 GiB changed* by +26.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash	main: `1ff318c`	merge: `dc9183c`	diff	diff %
ydbd size	3 012 101 352 Bytes	3 012 128 360 Bytes	+26.4 KiB	+0.001%
ydbd stripped size	477 607 224 Bytes	477 608 632 Bytes	+1.4 KiB	+0.000%

^{*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation}

(cherry picked from commit 80e5c94)

…7892 #10280 (#10341) Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com> Co-authored-by: Hor911 <hor911@ydb.tech>

github-actions bot added the not-for-changelog label Sep 17, 2024

yumkam changed the title ~~generic_lookup_actor: add basic error handling~~ [WIP]/[RFC] generic_lookup_actor: add basic error handling Sep 17, 2024

github-actions bot added not-for-changelog and removed not-for-changelog labels Sep 17, 2024

uzhastik reviewed Sep 17, 2024

View reviewed changes

ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp Show resolved Hide resolved

yumkam added 2 commits September 27, 2024 17:22

generic_lookup_actor: add basic error handling

da0e469

remove incomplete attempt to clean state

9649bd1

there should be no attempt to use generic lookup upon sending a error

yumkam force-pushed the add-generic-lookup-error-handling branch from 13469ec to 9649bd1 Compare September 27, 2024 14:22

yumkam changed the title ~~[WIP]/[RFC] generic_lookup_actor: add basic error handling~~ [RFC] generic_lookup_actor: add basic error handling Sep 27, 2024

github-actions bot removed the not-for-changelog label Sep 27, 2024

yumkam requested a review from uzhastik September 27, 2024 17:44

github-actions bot added the not-for-changelog label Sep 27, 2024

yumkam marked this pull request as ready for review September 30, 2024 13:50

yumkam requested review from a team as code owners September 30, 2024 13:50

yumkam changed the title ~~[RFC] generic_lookup_actor: add basic error handling~~ generic_lookup_actor: add basic error handling Oct 7, 2024

github-actions bot added not-for-changelog and removed not-for-changelog labels Oct 7, 2024

uzhastik previously approved these changes Oct 9, 2024

View reviewed changes

yumkam requested a review from rvu1024 October 9, 2024 11:11

rvu1024 reviewed Oct 9, 2024

View reviewed changes

ydb/library/yql/providers/generic/actors/yql_generic_lookup_actor.cpp Outdated Show resolved Hide resolved

fix review comment

bda8e23

yumkam dismissed uzhastik’s stale review via bda8e23 October 10, 2024 14:27

yumkam requested review from rvu1024 and uzhastik October 10, 2024 14:31

uzhastik approved these changes Oct 10, 2024

View reviewed changes

rvu1024 approved these changes Oct 10, 2024

View reviewed changes

uzhastik merged commit 80e5c94 into ydb-platform:main Oct 11, 2024
10 checks passed

yumkam added a commit to yumkam/ydb that referenced this pull request Oct 11, 2024

generic_lookup_actor: add basic error handling (ydb-platform#9396)

235c9f0

(cherry picked from commit 80e5c94)

yumkam added a commit to yumkam/ydb that referenced this pull request Oct 11, 2024

generic_lookup_actor: add basic error handling (ydb-platform#9396)

a6c3ccc

(cherry picked from commit 80e5c94)

yumkam added a commit that referenced this pull request Oct 18, 2024

Streamlookup stable backports #7782 #9758 #9396 #10283 #10489 #10508 #…

9a9711d

…7892 #10280 (#10341) Co-authored-by: dmasloff <74042473+dmasloff@users.noreply.github.com> Co-authored-by: Hor911 <hor911@ydb.tech>

This was referenced Oct 21, 2024

Fix kafka cdc read and login without @ #10678

Merged

Allow short auto partitioning strategies yql #10701

Merged

This was referenced Oct 23, 2024

YQ-3784 support computation graph invalidation in purecalc #10799

Merged

YQ RD pass UV from parser to filter #11078

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

generic_lookup_actor: add basic error handling #9396

generic_lookup_actor: add basic error handling #9396

yumkam commented Sep 17, 2024

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

uzhastik Sep 17, 2024

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

generic_lookup_actor: add basic error handling #9396

generic_lookup_actor: add basic error handling #9396

Conversation

yumkam commented Sep 17, 2024

Changelog entry

Changelog category

Additional information

github-actions bot commented Sep 17, 2024 • edited Loading

github-actions bot commented Sep 17, 2024 • edited Loading

github-actions bot commented Sep 17, 2024 • edited Loading

uzhastik Sep 17, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 27, 2024 • edited Loading

github-actions bot commented Sep 27, 2024 • edited Loading

github-actions bot commented Oct 10, 2024 • edited Loading

github-actions bot commented Oct 10, 2024 • edited Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Sep 27, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading

github-actions bot commented Oct 10, 2024 •

edited

Loading